Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value #180071

mattkae · 2025-12-18T15:44:06Z

What's new?

The viewId on the announce semantics event may be either an int32 or an int64, depending on what the codec perceives is best
We should parse either one of them on the Win32 side of things

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

loic-sharma · 2025-12-18T19:21:02Z

engine/src/flutter/shell/platform/windows/accessibility_plugin.cc

+    FlutterViewId view_id;
+    const auto* view_id_64 = std::get_if<FlutterViewId>(&view_itr->second);
+    const auto* view_id_32 = std::get_if<int32_t>(&view_itr->second);
+
+    if (view_id_64) {
+      view_id = *view_id_64;
+    } else if (view_id_32) {
+      view_id = static_cast<FlutterViewId>(*view_id_32);
+    } else {


I see EncodableValue::LongValue exists, but it throws:

flutter/engine/src/flutter/shell/platform/common/client_wrapper/include/flutter/encodable_value.h

Lines 205 to 217 in ca986c3

// Convenience method to simplify handling objects received from Flutter

// where the values may be larger than 32-bit, since they have the same type

// on the Dart side, but will be either 32-bit or 64-bit here depending on

// the value.

//

// Calling this method if the value doesn't contain either an int32_t or an

// int64_t will throw an exception.

int64_t LongValue() const {

if (std::holds_alternative<int32_t>(*this)) {

return std::get<int32_t>(*this);

}

return std::get<int64_t>(*this);

}

What do you think of adding a std::optional<int64_t> EncodableValue::TryGetLongValue() method?

This would let us simplify this logic, something like:

const auto view_id_val = view_itr->second.TryGetLongValue(); if (!view_id_val) { FML_LOG(ERROR) << "Announce message 'viewId' property must be a FlutterViewId."; return; } const auto view_id = static_cast<FlutterViewId>(*view_id_val); plugin->Announce(view_id, *message);

loic-sharma · 2025-12-18T19:29:40Z

This regression indicates we should have a test. What do you think of adding a accessibility_plugin_unittests.cc file that sends a message and verifies the mocks are called as expected? This might be useful prior art: https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/windows/cursor_handler_unittests.cc

…her an int32_t or an int64_t depending on its value

mattkae · 2025-12-19T14:54:28Z

This regression indicates we should have a test. What do you think of adding a accessibility_plugin_unittests.cc file that sends a message and verifies the mocks are called as expected? This might be useful prior art: https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/windows/cursor_handler_unittests.cc

Agree!

loic-sharma · 2025-12-19T18:59:02Z

engine/src/flutter/shell/platform/windows/accessibility_plugin_unittests.cc

+  messenger()->SimulateEngineMessage(
+      kAccessibilityChannelName, encoded->data(), encoded->size(),
+      [](const uint8_t* reply, size_t reply_size) {});
+}


Thanks for going above and beyond with these tests! :)

loic-sharma

Looks great, excellent work!

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

Manual roll Flutter from 57c3f8b to 6ff7f30 (83 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@57c3f8b...6ff7f30 2025-12-23 engine-flutter-autoroll@skia.org Roll Packages from f28cf2e to 5e3a766 (3 revisions) (flutter/flutter#180232) 2025-12-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CmFPyvSc-K8_WDd5p... to 5EgkVbjGVZmCFPdtR... (flutter/flutter#180230) 2025-12-23 engine-flutter-autoroll@skia.org Roll Skia from db7ec9a14905 to bdb147ae3040 (2 revisions) (flutter/flutter#180222) 2025-12-23 bruno.leroux@gmail.com Add SnackBarTheme (flutter/flutter#180001) 2025-12-23 engine-flutter-autoroll@skia.org Roll Skia from 0b1ba3920f1c to db7ec9a14905 (1 revision) (flutter/flutter#180219) 2025-12-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 31e9f619e18a to 94b05f717ba3 (1 revision) (flutter/flutter#180216) 2025-12-23 engine-flutter-autoroll@skia.org Roll Skia from a3e4f7b9d5f3 to 0b1ba3920f1c (1 revision) (flutter/flutter#180214) 2025-12-23 engine-flutter-autoroll@skia.org Roll Skia from b8517d1e25f7 to a3e4f7b9d5f3 (2 revisions) (flutter/flutter#180211) 2025-12-23 dkwingsmt@users.noreply.github.com [Engine] iOS style blurring (flutter/flutter#175458) 2025-12-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 2243e91acaf2 to 31e9f619e18a (1 revision) (flutter/flutter#180210) 2025-12-22 36861262+QuncCccccc@users.noreply.github.com Add error description for nbsp character(\u202f) (flutter/flutter#178895) 2025-12-22 engine-flutter-autoroll@skia.org Roll Skia from 98c01ea504d7 to b8517d1e25f7 (1 revision) (flutter/flutter#180207) 2025-12-22 116356835+AbdeMohlbi@users.noreply.github.com Small clean up in `LocalizationPlugin` (flutter/flutter#180053) 2025-12-22 engine-flutter-autoroll@skia.org Roll Skia from c5beca8fa90b to 98c01ea504d7 (2 revisions) (flutter/flutter#180202) 2025-12-22 engine-flutter-autoroll@skia.org Roll Dart SDK from cff33b09b24d to 2243e91acaf2 (1 revision) (flutter/flutter#180199) 2025-12-22 116356835+AbdeMohlbi@users.noreply.github.com Remove usages of Android's `AsyncTask` in favor of `java.util.concurrent` (flutter/flutter#180050) 2025-12-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 18ZvfJB61p7Z8HAaC... to CmFPyvSc-K8_WDd5p... (flutter/flutter#180193) 2025-12-22 engine-flutter-autoroll@skia.org Roll Skia from 7b7083ed9d57 to c5beca8fa90b (5 revisions) (flutter/flutter#180187) 2025-12-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 38812d17127d to cff33b09b24d (1 revision) (flutter/flutter#180185) 2025-12-22 engine-flutter-autoroll@skia.org Roll Skia from 0eef18a0e2e6 to 7b7083ed9d57 (1 revision) (flutter/flutter#180184) 2025-12-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 66c8013acbff to 38812d17127d (1 revision) (flutter/flutter#180179) 2025-12-21 engine-flutter-autoroll@skia.org Roll Skia from 6fbc6c75b9bb to 0eef18a0e2e6 (2 revisions) (flutter/flutter#180176) 2025-12-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kGnnY1-fTWwYAnk8e... to 18ZvfJB61p7Z8HAaC... (flutter/flutter#180173) 2025-12-21 engine-flutter-autoroll@skia.org Roll Skia from 1a4ca755288a to 6fbc6c75b9bb (1 revision) (flutter/flutter#180167) 2025-12-20 engine-flutter-autoroll@skia.org Roll Skia from 2ad7452bd9d1 to 1a4ca755288a (1 revision) (flutter/flutter#180160) 2025-12-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from oe10epXkqGnv21AbZ... to kGnnY1-fTWwYAnk8e... (flutter/flutter#180158) 2025-12-20 engine-flutter-autoroll@skia.org Roll Skia from b01ad49ea807 to 2ad7452bd9d1 (1 revision) (flutter/flutter#180155) 2025-12-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 8fb1c0c0a8ae to 66c8013acbff (1 revision) (flutter/flutter#180154) 2025-12-20 737941+loic-sharma@users.noreply.github.com Remove unnecessary RadioGroup migration TODOs (flutter/flutter#180105) 2025-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[reland] Unify canvas creation and Surface code in Skwasm and CanvasKit (#179473)" (flutter/flutter#180152) 2025-12-20 engine-flutter-autoroll@skia.org Roll Skia from 3cc7e81928f0 to b01ad49ea807 (1 revision) (flutter/flutter#180151) 2025-12-20 engine-flutter-autoroll@skia.org Roll Dart SDK from ac95c6e8a31d to 8fb1c0c0a8ae (1 revision) (flutter/flutter#180148) 2025-12-19 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#180146) 2025-12-19 engine-flutter-autoroll@skia.org Roll Skia from fa4434632ce6 to 3cc7e81928f0 (4 revisions) (flutter/flutter#180142) 2025-12-19 1961493+harryterkelsen@users.noreply.github.com [reland] Unify canvas creation and Surface code in Skwasm and CanvasKit (flutter/flutter#179473) 2025-12-19 engine-flutter-autoroll@skia.org Roll Skia from ae5dd72b3591 to fa4434632ce6 (2 revisions) (flutter/flutter#180136) 2025-12-19 45459898+RamonFarizel@users.noreply.github.com Semantics headingLeveldoc update (flutter/flutter#179999) 2025-12-19 matt.kosarek@canonical.com Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value (flutter/flutter#180071) 2025-12-19 bkonyi@google.com [ Web ] Pass `--enable-experimental-ffi` when compiling WASM tests (flutter/flutter#180127) 2025-12-19 engine-flutter-autoroll@skia.org Roll Dart SDK from cfc117d10d36 to ac95c6e8a31d (1 revision) (flutter/flutter#180130) 2025-12-19 58529443+srujzs@users.noreply.github.com Pass canaryFeatures to BuildSettings (flutter/flutter#180108) 2025-12-19 engine-flutter-autoroll@skia.org Roll Skia from fe2be289c9fe to ae5dd72b3591 (1 revision) (flutter/flutter#180129) 2025-12-19 engine-flutter-autoroll@skia.org Roll Packages from 6f392aa to f28cf2e (1 revision) (flutter/flutter#180124) 2025-12-19 94012149+richardexfo@users.noreply.github.com Set text input purpose and hints on Linux platform (flutter/flutter#180013) ...

github-actions bot added engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Dec 18, 2025

mattkae requested a review from loic-sharma December 18, 2025 15:44

mattkae marked this pull request as ready for review December 18, 2025 15:44

loic-sharma reviewed Dec 18, 2025

View reviewed changes

Fix an issue where the semantics announce event may be encoded as eit…

826d82d

…her an int32_t or an int64_t depending on its value

mattkae requested a review from loic-sharma December 19, 2025 14:59

loic-sharma reviewed Dec 19, 2025

View reviewed changes

loic-sharma approved these changes Dec 19, 2025

View reviewed changes

mattkae added this pull request to the merge queue Dec 19, 2025

mattkae added 2 commits December 19, 2025 14:41

Add unittests

32e84e8

Add TryGetLongValue to EncodableValue

643b24d

Merged via the queue into flutter:master with commit a214a35 Dec 19, 2025
178 of 179 checks passed

mattkae deleted the bugfix/179563 branch December 19, 2025 20:20

engine-flutter-autoroll mentioned this pull request Dec 20, 2025

Roll Flutter from 6e1aa823523d to 299c3e62e6b8 (144 revisions) flutter/packages#10655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

6a31308

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 20, 2025

Roll Flutter from 6e1aa823523d to 299c3e62e6b8 (144 revisions) flutter/packages#10657

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

32fa6e0

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 21, 2025

Roll Flutter from 6e1aa823523d to a73d5998e986 (146 revisions) flutter/packages#10658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

2baeda3

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 21, 2025

Roll Flutter from 6e1aa823523d to d4cd9a2f4b53 (147 revisions) flutter/packages#10659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

e910183

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 21, 2025

Roll Flutter from 6e1aa823523d to d4cd9a2f4b53 (147 revisions) flutter/packages#10660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

a634846

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 22, 2025

Roll Flutter from 6e1aa823523d to d2b3853186f8 (152 revisions) flutter/packages#10664

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

dd12846

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 22, 2025

Roll Flutter from 6e1aa823523d to d2b3853186f8 (152 revisions) flutter/packages#10665

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

1716c80

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 22, 2025

Roll Flutter from 6e1aa823523d to 1ba333368514 (153 revisions) flutter/packages#10666

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

891af38

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Roll Flutter from 6e1aa823523d to cd9e44ff10ca (166 revisions) flutter/packages#10668

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

9797af0

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Roll Flutter from 6e1aa823523d to 0974193a6c68 (167 revisions) flutter/packages#10669

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

1c11d7f

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Roll Flutter from 6e1aa823523d to 6ff7f300473f (168 revisions) flutter/packages#10670

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

6a11732

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Roll Flutter from d81baabfec4c to b568f332e548 (122 revisions) flutter/packages#10672

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

9c01f50

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Roll Flutter from d81baabfec4c to efce5d7e5578 (123 revisions) flutter/packages#10673

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

e5984df

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

engine-flutter-autoroll mentioned this pull request Dec 23, 2025

Manual roll Flutter from 57c3f8b66525 to 6ff7f300473f (83 revisions) flutter/packages#10674

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025

a214a35 Fix an issue where the semantics announce event may be encode…

48dbeae

…d as either an int32_t or an int64_t depending on its value (flutter/flutter#180071)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value #180071

Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value #180071

Uh oh!

mattkae commented Dec 18, 2025

Uh oh!

loic-sharma Dec 18, 2025

Uh oh!

mattkae Dec 19, 2025 •

edited

Loading

Uh oh!

loic-sharma commented Dec 18, 2025

Uh oh!

mattkae commented Dec 19, 2025

Uh oh!

loic-sharma Dec 19, 2025

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// Convenience method to simplify handling objects received from Flutter
	// where the values may be larger than 32-bit, since they have the same type
	// on the Dart side, but will be either 32-bit or 64-bit here depending on
	// the value.
	//
	// Calling this method if the value doesn't contain either an int32_t or an
	// int64_t will throw an exception.
	int64_t LongValue() const {
	if (std::holds_alternative<int32_t>(*this)) {
	return std::get<int32_t>(*this);
	}
	return std::get<int64_t>(*this);
	}

Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value #180071

Fix an issue where the semantics announce event may be encoded as either an int32_t or an int64_t depending on its value #180071

Uh oh!

Conversation

mattkae commented Dec 18, 2025

What's new?

Pre-launch Checklist

Uh oh!

loic-sharma Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

mattkae Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Dec 18, 2025

Uh oh!

mattkae commented Dec 19, 2025

Uh oh!

loic-sharma Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattkae Dec 19, 2025 •

edited

Loading