Prevent calling setStatusBarColor on API_35 and update related documentation
#180062
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated deprecated method documentation and replaced direct API level reference with static import.
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates FlutterFragmentActivity to handle the deprecation of setStatusBarColor in Android 15 (API 35). A conditional check is added to ensure this method is only called on SDK versions lower than 35. The Javadoc for the deprecated method has also been updated to be more descriptive. My review points out a minor grammatical error in the documentation and suggests refactoring a magic number to a constant to improve code readability.
...src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java
Outdated
Show resolved
Hide resolved
...src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java
Show resolved
Hide resolved
…/android/FlutterFragmentActivity.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
setStatusBarColor on API_35 and update related documentation
camsim99
reviewed
Jan 5, 2026
Contributor
camsim99
left a comment
There was a problem hiding this comment.
LGTM, just one comment on wording in the deprecation note!
...src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java
Outdated
Show resolved
Hide resolved
Updated deprecation notice to include link to WindowInsetsController documentation.
camsim99
approved these changes
Jan 6, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/180062, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Contributor
|
autosubmit label was removed for flutter/flutter/180062, because - The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/flutter/180062, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…lated documentation (flutter/flutter#180062)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…lated documentation (flutter/flutter#180062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see : #165327 (comment)
towards #165327 (see https://discord.com/channels/608014603317936148/846507907876257822/1451187625116569660)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.