Skip to content

Update link to FlutterTest font generation script#179957

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
lsaudon:patch-1
Jan 13, 2026
Merged

Update link to FlutterTest font generation script#179957
auto-submit[bot] merged 2 commits into
flutter:masterfrom
lsaudon:patch-1

Conversation

@lsaudon

@lsaudon lsaudon commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Dec 16, 2025
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 16, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a broken link to the gen_test_font.py script. The change correctly points to the script's new location, but I've suggested a minor improvement to use main instead of master in the URL to align with the repository's current default branch.

Comment thread docs/contributing/testing/Flutter-Test-Fonts.md Outdated
justinmc
justinmc approved these changes Dec 30, 2025
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Another option would be to use the permalink (https://github.com/flutter/flutter/blob/2311c0fde6587f39d52c36baa5f14023f3c734f4/engine/src/flutter/tools/gen_test_font.py). But I guess we want the latest version of the file. In exchange for risking a broken link if this moves again someday.

@justinmc justinmc requested a review from victorsanni December 30, 2025 23:34
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026
@auto-submit

auto-submit Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/179957, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 13, 2026
Merged via the queue into flutter:master with commit 93d36ef Jan 13, 2026
9 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
fd6aa8c 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
89d69de 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
cd230de 
…utter#179957)
@lsaudon lsaudon deleted the patch-1 branch January 14, 2026 16:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
dd73058 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
55f3739 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 15, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
0378d9d 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
2d6f604 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
9a199b8 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
2f06489 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
55d1029 
…utter#179957)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
5dd39bb 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
a2aafac 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
55a8e82 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
f8db44d 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
613d1fd 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
fc9081d 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
01347ab 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
e46b9bd 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
4a39d96 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
1da3943 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
c5bbc20 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
20301f8 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
343dfc9 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
8112fb7 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
870d417 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
cdff308 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
ea2c682 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
e67759f 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
6b0ee25 
…utter#179957)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
@engine-flutter-autoroll
93d36ef Update link to FlutterTest font generation script (flutter/fl…
f0e794b 
…utter#179957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes
@victorsanni victorsanni victorsanni approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsaudon @justinmc @victorsanni