Allow windows to be created undecorated#179859
Conversation
This will be useful when we want to render all the window decorations using Flutter.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request introduces the functionality to create undecorated windows across macOS, Windows, and Linux platforms. The changes are well-structured, touching native code for each platform as well as the Dart framework layer to expose the new decorated property. While the implementation is largely correct, I've identified a few critical issues on Windows and macOS that need to be addressed. These include incorrect argument ordering in a function call on Windows and a missing parameter in a method on macOS, which could lead to incorrect behavior or build failures. There is also a minor logic issue with window styles for undecorated dialogs on Windows.
|
I've just guessed the Win32/MacOS APIs from documentation, so please check if these actually work! |
|
See #179964 for related PR to allow window moving and resizing. |
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to create undecorated windows across macOS, Windows, and Linux platforms by adding a decorated flag to the window creation APIs. The changes are propagated from the engine level up to the public Dart API in _window.dart. The example application is also updated to demonstrate this new feature.
My review focuses on ensuring the correct use of the new APIs, code clarity, and adherence to documentation standards. I've identified a minor issue in the example application and suggested some code simplifications for better readability in the Linux implementation. I've also pointed out missing documentation for the new public API parameters.
This will be useful when we want to render all the window decorations using Flutter. Fixes flutter#183557
This will be useful when we want to render all the window decorations using Flutter. Fixes flutter#183557
This will be useful when we want to render all the window decorations using Flutter.
Fixes #183557