-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix Gradient.scale not preserving transformation. #179493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gradient.scale not preserving transformation. #179493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue where Gradient.scale did not preserve the transform property on LinearGradient, RadialGradient, and SweepGradient. The changes in gradient.dart properly pass the transform to the new gradient instances. The accompanying tests in gradient_test.dart effectively verify this fix. I've found a minor issue in the expected color values within the new tests and have provided suggestions to correct them.
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
autosubmit label was removed for flutter/flutter/179493, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Fixes #163972
Description
Gradient.scalemethods to not lose transformCode sample
Pre-launch Checklist
///).