Make sure that a CupertinoListTileChevron doesn't crash in 0x0 enviro… #179165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test for a crash in CupertinoListTileChevron. While adding tests is great, the fix for the crash itself seems to be missing from this PR. The test is also flawed as it doesn't correctly reproduce the crash conditions, which I've detailed in a specific comment. Please add the fix and update the test to ensure it properly covers the failure case.
Comment on lines
+552
to
+559
| testWidgets('CupertinoListTileChevron does not crash at zero area', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| const CupertinoApp( | ||
| home: Center(child: SizedBox.shrink(child: CupertinoListTileChevron())), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(CupertinoListTileChevron)), Size.zero); | ||
| }); |
Contributor
There was a problem hiding this comment.
This test aims to prevent a crash in CupertinoListTileChevron when it's used in an environment without a MediaQuery. However, by wrapping the widget under test in CupertinoApp, a MediaQuery is provided, which masks the original issue. This means the test will pass even without the fix, defeating its purpose as a regression test.
To properly test the fix, the test environment should replicate the conditions of the original crash, which means running without an ambient MediaQuery that provides text scaling information. Consider removing CupertinoApp and constructing a more minimal widget tree for this test.
victorsanni
approved these changes
Dec 1, 2025
Contributor
victorsanni
left a comment
There was a problem hiding this comment.
Maybe in the 0x0 CupertinoListTile test we can also check for the chevron?
Contributor
Author
|
Done. Check the CupertinoListTile PR. |
dkwingsmt
approved these changes
Dec 5, 2025
Contributor
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2025
This was referenced Dec 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2025
This was referenced Dec 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 8, 2025
Roll Flutter from 5b87203 to b2de367 (38 revisions) flutter/flutter@5b87203...b2de367 2025-12-08 engine-flutter-autoroll@skia.org Roll Packages from b17d3ff to 33a9a81 (3 revisions) (flutter/flutter#179579) 2025-12-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XCoAHsnYnKrvuWU2o... to _pSztGZvEA3-Ry-GW... (flutter/flutter#179575) 2025-12-08 matt.kosarek@canonical.com Implementation of `TestWindowingOwner` for testing multi-window (flutter/flutter#179355) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 11efe37089a7 to 75899721aa42 (2 revisions) (flutter/flutter#179573) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 0c016e4aefd5 to b1936c760645 (8 revisions) (flutter/flutter#179568) 2025-12-08 engine-flutter-autoroll@skia.org Roll Skia from 3c5f9e0c9269 to 0c016e4aefd5 (1 revision) (flutter/flutter#179565) 2025-12-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 1a6c6f6398af to 11efe37089a7 (1 revision) (flutter/flutter#179564) 2025-12-07 engine-flutter-autoroll@skia.org Roll Skia from 4830855b6f84 to 3c5f9e0c9269 (1 revision) (flutter/flutter#179561) 2025-12-07 engine-flutter-autoroll@skia.org Roll Skia from d5a6b6af6d12 to 4830855b6f84 (1 revision) (flutter/flutter#179557) 2025-12-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KilaJW3p3J_0yUDtV... to XCoAHsnYnKrvuWU2o... (flutter/flutter#179551) 2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from 33b32cecb287 to d5a6b6af6d12 (1 revision) (flutter/flutter#179540) 2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from ea201dd2ef12 to 1a6c6f6398af (1 revision) (flutter/flutter#179539) 2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d30ee8d5a0 to ea201dd2ef12 (1 revision) (flutter/flutter#179537) 2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 30c906aa00f2 to d1d30ee8d5a0 (1 revision) (flutter/flutter#179534) 2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from dccd48c6c6ab to 33b32cecb287 (2 revisions) (flutter/flutter#179531) 2025-12-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vDeTl_KBeLJY8nCAx... to KilaJW3p3J_0yUDtV... (flutter/flutter#179530) 2025-12-06 engine-flutter-autoroll@skia.org Roll Dart SDK from f3690c23d422 to 30c906aa00f2 (2 revisions) (flutter/flutter#179529) 2025-12-06 engine-flutter-autoroll@skia.org Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (flutter/flutter#179524) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoFormRow doesn't crash in 0x0 environment (flutter/flutter#178979) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoContextMenuAction doesn't crash in 0x0 envi… (flutter/flutter#178721) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoRadio doesn't crash in 0x0 environment (flutter/flutter#179378) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoSearchTextField doesn't crash in 0x0 enviro… (flutter/flutter#179487) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoPicker doesn't crash in 0x0 environment (flutter/flutter#179258) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoAlertDialog doesn't crash in 0x0 environment (flutter/flutter#178858) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoListTileChevron doesn't crash in 0x0 enviro… (flutter/flutter#179165) 2025-12-05 ahmedsameha1@gmail.com Make sure that CupertinoNavigationBar doesn't crash in 0x0 environment (flutter/flutter#179235) 2025-12-05 ahmedsameha1@gmail.com Replace dropdown button with dropdown menu (flutter/flutter#179095) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoCheckbox doesn't crash in 0x0 environment (flutter/flutter#178630) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoApp doesn't crash in 0x0 environment (flutter/flutter#178610) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoButton doesn't crash in 0x0 environment (flutter/flutter#178629) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoTimerPicker doesn't crash in 0x0 environment (flutter/flutter#178857) 2025-12-05 ahmedsameha1@gmail.com Make sure that a CupertinoScrollbar doesn't crash in 0x0 environment (flutter/flutter#179442) 2025-12-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 0fcab487446d to f3690c23d422 (1 revision) (flutter/flutter#179517) 2025-12-05 bruno.leroux@gmail.com Update several comments related to theme normalization (flutter/flutter#179457) 2025-12-05 ttankkeo112@gmail.com Reimplemented StretchingOverscrollIndicator with Simulation ported from Android 12. (flutter/flutter#173849) 2025-12-05 engine-flutter-autoroll@skia.org Roll Skia from a31411879251 to e19670f70406 (1 revision) (flutter/flutter#179511) 2025-12-05 codefu@google.com chore: mark tests as flaky (flutter/flutter#179518) 2025-12-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 42fe3327abca to 0fcab487446d (3 revisions) (flutter/flutter#179506) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter#179165) This is my attempt to handle flutter#6537 for the CupertinoListTileChevron widget. Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the CupertinoListTileChevron widget.