Pin package:dwds to 26.1.0#178327
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request pins the dwds package to version 26.1.0 in packages/flutter_tools/lib/src/update_packages_pins.dart. This is done to avoid bugs present in version 26.2.2 that cause failures, as documented in the associated issue. The change correctly follows the project's conventions for pinning dependencies, including adding a comment with a link to the relevant issue and maintaining alphabetical order in the list.
Piinks
left a comment
There was a problem hiding this comment.
LGTM so we can land the pub roller, although to follow up on in the upcoming dash forum proposal to unpin deps.
See #178326