[Impeller] Use 32-bit index values in the tessellator if the platform supports it#178088
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for 32-bit index values in the tessellator for platforms that support it, addressing potential overflows with 16-bit indices for paths with a large number of points. The changes correctly add a new capability, Supports32BitPrimitiveIndices, and implement it for Vulkan and GLES backends. The Tessellator class is refactored to use a templated implementation that can be instantiated with either uint16_t or uint32_t for indices, based on the detected capability. This is a solid approach to handle the different index sizes. I have one suggestion to reduce code duplication in the new tessellator implementation.
chinmaygarde
approved these changes
Nov 10, 2025
| } | ||
|
|
||
| bool CapabilitiesVK::Supports32BitPrimitiveIndices() const { | ||
| return true; |
Contributor
There was a problem hiding this comment.
Seems unnecessary as this is the default.
74839ca to
c45ee37
Compare
… supports it Applications may try to render paths whose point count exceeds the bounds of a 16-bit index. This PR changes the tessellator to use 32-bit indices when available but will fall back to 16-bit on platforms that do not support it (specifically OpenGL ES implementations without the necessary extension). Fixes flutter#175031 Fixes flutter#178022
acc64f9 to
a3b5cf7
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…platform supports it (flutter/flutter#178088)
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
… supports it (flutter#178088) Applications may try to render paths whose point count exceeds the bounds of a 16-bit index. This PR changes the tessellator to use 32-bit indices when available but will fall back to 16-bit on platforms that do not support it (specifically OpenGL ES implementations without the necessary extension). Fixes flutter#175031 Fixes flutter#178022
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
… supports it (flutter#178088) Applications may try to render paths whose point count exceeds the bounds of a 16-bit index. This PR changes the tessellator to use 32-bit indices when available but will fall back to 16-bit on platforms that do not support it (specifically OpenGL ES implementations without the necessary extension). Fixes flutter#175031 Fixes flutter#178022
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
… supports it (flutter#178088) Applications may try to render paths whose point count exceeds the bounds of a 16-bit index. This PR changes the tessellator to use 32-bit indices when available but will fall back to 16-bit on platforms that do not support it (specifically OpenGL ES implementations without the necessary extension). Fixes flutter#175031 Fixes flutter#178022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2026
…platform supports it (flutter/flutter#178088)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications may try to render paths whose point count exceeds the bounds of a 16-bit index. This PR changes the tessellator to use 32-bit indices when available but will fall back to 16-bit on platforms that do not support it (specifically OpenGL ES implementations without the necessary extension).
Fixes #175031
Fixes #178022