refactor: Migrate Expansible animation properties to AnimationStyle for a less broad API surface#177966
Merged
auto-submit[bot] merged 3 commits intoNov 11, 2025
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Expansible widget to use AnimationStyle for its animation properties, deprecating the older duration, curve, and reverseCurve properties. This change aligns Expansible with other Flutter widgets and aims for a cleaner API surface. The implementation includes the necessary widget updates, data-driven fixes for smooth user migration, and new tests. My review found a couple of areas for improvement: the documentation for the new animationStyle property is confusing and contains an error, and a test case could be made more explicit to better reflect its purpose. Overall, this is a good refactoring that improves API consistency.
Comment on lines
+264
to
+266
| /// If [AnimationStyle.duration] or [AnimationStyle.reverseDuration] is | ||
| /// provided, it will be used to override [duration]. If it is null, then | ||
| /// [duration] will be used. Otherwise, defaults to 200ms. |
Contributor
There was a problem hiding this comment.
This documentation paragraph is confusing and contains an error. It incorrectly mentions AnimationStyle.reverseDuration, which is not used by Expansible. The phrasing with If it is null and Otherwise is also ambiguous.
Please consider rephrasing for clarity. The following paragraphs for curve and reverseCurve have similar clarity issues.
/// If [AnimationStyle.duration] is provided, it will be used instead of
/// [duration]. If not provided, [duration] is used, which defaults to
/// 200ms.
Contributor
There was a problem hiding this comment.
This is an interesting question. I wonder, should Expansible support reverse duration? Maybe for closing? Or would that potentially be confusing based on the initial state?
Contributor
There was a problem hiding this comment.
It does have a reverse curve, so I guess reverse duration would apply in that scenario. Probably good to consider as a separate change rather than lumped with this one. :)
Contributor
Author
There was a problem hiding this comment.
Yes, I will update comment here and add reverseDuration in upcoming PR(if required).
Comment on lines
+420
to
+422
| testWidgets('AnimationStyle takes precedence over deprecated properties', ( | ||
| WidgetTester tester, | ||
| ) async { |
Contributor
There was a problem hiding this comment.
This test is correctly named 'AnimationStyle takes precedence over deprecated properties', but it only implicitly tests this by checking that animationStyle overrides the default values of the deprecated properties. To make the test's intent more explicit and robust, consider explicitly passing values for the deprecated duration and curve properties in the Expansible constructor and asserting they are ignored.
1fb8a30 to
462c61f
Compare
victorsanni
reviewed
Nov 4, 2025
victorsanni
left a comment
Contributor
There was a problem hiding this comment.
linux analyze is failing because packages/flutter/test_fixes/widgets/widgets.dart isn't formatted correctly.
89fe6a2 to
382c2f2
Compare
382c2f2 to
35baecd
Compare
victorsanni
approved these changes
Nov 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…nStyle for a less broad API surface (flutter/flutter#177966)
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
…or a less broad API surface (flutter#177966) * Add animationStyle to Exapnsible * Mark duration, curve and reverseCurve as deprecated * Add data driven fixes fixes: flutter#177799 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…or a less broad API surface (flutter#177966) ## Changes * Add animationStyle to Exapnsible * Mark duration, curve and reverseCurve as deprecated * Add data driven fixes fixes: flutter#177799 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…or a less broad API surface (flutter#177966) ## Changes * Add animationStyle to Exapnsible * Mark duration, curve and reverseCurve as deprecated * Add data driven fixes fixes: flutter#177799 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2026
…nStyle for a less broad API surface (flutter/flutter#177966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fixes: #177799
Pre-launch Checklist
///).