flutter_tools: correct iOS signing log for manual code signing (CODE_SIGN_STYLE=Manual) by MohammedTarigg · Pull Request #177852 · flutter/flutter

MohammedTarigg · 2025-10-31T18:10:26Z

Summary

When running flutter build ipa with a project that uses manual code signing (CODE_SIGN_STYLE=Manual) for Release/Profile, the tool currently prints:

Automatically signing iOS for device deployment using specified development team in Xcode project: x

This is misleading in two ways:

The project is not using automatic signing for Release/Profile, it's explicitly using manual signing with a provisioning profile.
The build in this mode is typically for App Store/TestFlight distribution, not just device deployment.

Users who rely on manual signing (for example, Push Notifications + Sign in with Apple entitlements) often hit an xcodebuild -exportArchive failure later ("Runner.app" requires a provisioning profile ...) and assume Flutter overrode their signing, because of this log line. This confusion has been reported in the context of flutter build ipa where archive succeeds but export fails, and Flutter's messaging doesn't match the actual signing setup.

Related issues:

Support flutter build ipa with manual signing and provisioning profiles #106612 - Support flutter build ipa with manual signing and provisioning profiles
Flutter build IPA with --export-options-plist not working #113977 - Flutter build IPA with --export-options-plist not working

What this change does

Before logging "Automatically signing iOS ...", we now check the active build configuration's CODE_SIGN_STYLE.
If the style is Manual, we suppress the automatic-signing message (since manual signing is not automatic).
If the style is Automatic or not set, we keep the original behavior.
No functional behavior of signing or export is changed.

Before

Automatically signing iOS for device deployment using specified development team in Xcode project: x

(This message appears even when CODE_SIGN_STYLE=Manual)

After

(No message when CODE_SIGN_STYLE=Manual, since signing is not automatic)

(The message only appears when CODE_SIGN_STYLE=Automatic or not set)

Tests

Added test in packages/flutter_tools/test/general.shard/ios/code_signing_test.dart to assert we don't emit the automatic-signing message when CODE_SIGN_STYLE=Manual.
All existing tests pass (40/40 tests in code_signing_test.dart).

Why this helps

Reduces confusion around manual signing / App Store export flows.
Matches expectations from users who configure provisioning profiles manually and expect Flutter to respect that configuration.
Prevents users from thinking Flutter is overriding their manual signing setup based on misleading log output.

Breaking Changes

None. This change only affects log output and does not modify any signing behavior, export behavior, or CLI interface.

Verification

Reviewers can verify this fix by:

Creating a test iOS project with CODE_SIGN_STYLE=Manual and DEVELOPMENT_TEAM set in Xcode project settings
Running flutter build ipa --release --verbose
Confirming the log does NOT show "Automatically signing iOS..."
Verifying the app still builds/signs correctly

The included unit test covers this scenario automatically.

Supersedes #177851 (that PR accidentally included unrelated commits from my fork history). This version only includes the intended change and tests.

google-cla · 2025-10-31T18:10:32Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request corrects a misleading log message that appeared during iOS builds using manual code signing. The change adds a condition to check the CODE_SIGN_STYLE from the build settings. If the style is 'Manual', it correctly suppresses the 'Automatically signing...' log. This is a good improvement as it reduces user confusion. A new test is included to verify that the log message is not displayed for manual signing setups, ensuring the fix is effective. The implementation is straightforward and the changes look good.

MohammedTarigg · 2025-10-31T18:19:04Z

CLA signed

MohammedTarigg · 2025-10-31T20:00:32Z

CI Status Follow-up

I see the ci.yaml validation check is failing. Since this PR only modifies:

packages/flutter_tools/lib/src/ios/code_signing.dart (logging logic)
packages/flutter_tools/test/general.shard/ios/code_signing_test.dart (unit test)

This appears unrelated to ci.yaml configuration. Could the maintainers please review the ci.yaml failure to determine if it's a check issue or requires action on my end?

All other checks (CLA, code review) are passing. The fix is minimal, focused, and includes test coverage.

…nual When DEVELOPMENT_TEAM is set in the Xcode project but CODE_SIGN_STYLE is Manual, Flutter was still logging 'Automatically signing iOS...' which is misleading since manual signing is not automatic. This change checks CODE_SIGN_STYLE before logging the automatic signing message. If it's Manual, no message is logged (or a more accurate message could be logged in the future). Fixes the misleading log output for users who use manual code signing with ExportOptions.plist for App Store distribution.

…t.dart test(code_signing): assert manual signing does NOT log "Automatically signing..." Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

…=Manual test Addresses reviewer feedback to explicitly test that the misleading 'Auto signing iOS...' message is not present, rather than just checking isEmpty. Uses single quotes and proper formatting.

vashworth · 2025-11-13T17:34:28Z

@LouiseHsu Can you do a second review?

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

…SIGN_STYLE=Manual) (flutter#177852) ## Summary When running `flutter build ipa` with a project that uses manual code signing (`CODE_SIGN_STYLE=Manual`) for Release/Profile, the tool currently prints: ``` Automatically signing iOS for device deployment using specified development team in Xcode project: x ``` This is misleading in two ways: 1. The project is not using automatic signing for Release/Profile, it's explicitly using manual signing with a provisioning profile. 2. The build in this mode is typically for App Store/TestFlight distribution, not just device deployment. Users who rely on manual signing (for example, Push Notifications + Sign in with Apple entitlements) often hit an `xcodebuild -exportArchive` failure later (`"Runner.app" requires a provisioning profile ...`) and assume Flutter overrode their signing, because of this log line. This confusion has been reported in the context of `flutter build ipa` where archive succeeds but export fails, and Flutter's messaging doesn't match the actual signing setup. **Related issues:** - flutter#106612 - Support `flutter build ipa` with manual signing and provisioning profiles - flutter#113977 - Flutter build IPA with --export-options-plist not working ## What this change does * Before logging "Automatically signing iOS ...", we now check the active build configuration's `CODE_SIGN_STYLE`. * If the style is `Manual`, we suppress the automatic-signing message (since manual signing is not automatic). * If the style is `Automatic` or not set, we keep the original behavior. * No functional behavior of signing or export is changed. ## Before ``` Automatically signing iOS for device deployment using specified development team in Xcode project: x ``` (This message appears even when `CODE_SIGN_STYLE=Manual`) ## After ``` (No message when CODE_SIGN_STYLE=Manual, since signing is not automatic) ``` (The message only appears when `CODE_SIGN_STYLE=Automatic` or not set) ## Tests * Added test in `packages/flutter_tools/test/general.shard/ios/code_signing_test.dart` to assert we don't emit the automatic-signing message when `CODE_SIGN_STYLE=Manual`. * All existing tests pass (40/40 tests in code_signing_test.dart). ## Why this helps * Reduces confusion around manual signing / App Store export flows. * Matches expectations from users who configure provisioning profiles manually and expect Flutter to respect that configuration. * Prevents users from thinking Flutter is overriding their manual signing setup based on misleading log output. ## Breaking Changes None. This change only affects log output and does not modify any signing behavior, export behavior, or CLI interface. ## Verification Reviewers can verify this fix by: 1. Creating a test iOS project with `CODE_SIGN_STYLE=Manual` and `DEVELOPMENT_TEAM` set in Xcode project settings 2. Running `flutter build ipa --release --verbose` 3. Confirming the log does NOT show "Automatically signing iOS..." 4. Verifying the app still builds/signs correctly The included unit test covers this scenario automatically. --- Supersedes flutter#177851 (that PR accidentally included unrelated commits from my fork history). This version only includes the intended change and tests. --------- Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

MohammedTarigg requested a review from a team as a code owner October 31, 2025 18:10

MohammedTarigg mentioned this pull request Oct 31, 2025

flutter_tools: correct iOS signing log for manual code signing (CODE_SIGN_STYLE=Manual) #177851

Closed

github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Oct 31, 2025

gemini-code-assist Bot reviewed Oct 31, 2025

View reviewed changes

MohammedTarigg force-pushed the fix-ios-signing-log-clean branch 2 times, most recently from aca02ed to a8bbfd5 Compare October 31, 2025 22:21

navaronbracke reviewed Oct 31, 2025

View reviewed changes

Comment thread packages/flutter_tools/test/general.shard/ios/code_signing_test.dart Outdated

This was referenced Nov 2, 2025

Support flutter build ipa with manual signing and provisioning profiles #106612

Open

flutter build ipa fails for manual signing unless a custom ExportOptions.plist is provided (Push Notifications / Sign in with Apple entitlements) #177853

Closed

hellohuanlin requested a review from vashworth November 6, 2025 22:25

MohammedTarigg and others added 3 commits November 8, 2025 13:24

Update packages/flutter_tools/test/general.shard/ios/code_signing_tes…

4014f4d

…t.dart test(code_signing): assert manual signing does NOT log "Automatically signing..." Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>

test: use explicit expectation with single quotes for CODE_SIGN_STYLE…

6ebb110

…=Manual test Addresses reviewer feedback to explicitly test that the misleading 'Auto signing iOS...' message is not present, rather than just checking isEmpty. Uses single quotes and proper formatting.

MohammedTarigg force-pushed the fix-ios-signing-log-clean branch from df4408b to 6ebb110 Compare November 8, 2025 10:24

vashworth approved these changes Nov 13, 2025

View reviewed changes

vashworth requested a review from LouiseHsu November 13, 2025 15:47

LouiseHsu approved these changes Nov 13, 2025

View reviewed changes

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2025

auto-submit Bot added this pull request to the merge queue Nov 13, 2025

Merged via the queue into flutter:master with commit e98205f Nov 13, 2025
145 of 146 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2025

engine-flutter-autoroll mentioned this pull request Nov 14, 2025

Roll Flutter from ee23168ddb5d to 35b8aca9c2ce (103 revisions) flutter/packages#10426

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

ebc42fd

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

aefe578

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 14, 2025

Roll Flutter from ee23168ddb5d to 4b55ea85fd18 (105 revisions) flutter/packages#10430

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

86f5e45

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 14, 2025

Manual roll Flutter from ee23168ddb5d to 5798e1a28622 (106 revisions) flutter/packages#10432

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

b235c80

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

Piinks mentioned this pull request Nov 14, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll mentioned this pull request Nov 15, 2025

Roll Flutter from 9b5ad8031646 to 5ae70ee7c058 (112 revisions) flutter/packages#10437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

4009dc6

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 15, 2025

Roll Flutter from 9b5ad8031646 to 5ae70ee7c058 (112 revisions) flutter/packages#10438

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

b43e388

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 16, 2025

Roll Flutter from 9b5ad8031646 to 0924c0c2bb0e (117 revisions) flutter/packages#10441

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

50b48ea

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 16, 2025

Roll Flutter from 9b5ad8031646 to 505aa720015a (118 revisions) flutter/packages#10442

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

b37b63b

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 16, 2025

Roll Flutter from 9b5ad8031646 to f954fb79dd15 (119 revisions) flutter/packages#10444

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

13c3321

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 17, 2025

Roll Flutter from 9b5ad8031646 to 40f3b2e6e6a9 (123 revisions) flutter/packages#10447

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

ed00698

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 17, 2025

Roll Flutter from 9b5ad8031646 to ce7d9b9882c0 (125 revisions) flutter/packages#10449

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

5d20536

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 17, 2025

Roll Flutter from 9b5ad8031646 to c546757beb28 (127 revisions) flutter/packages#10451

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

12cabce

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll mentioned this pull request Nov 17, 2025

Roll Flutter from 9b5ad8031646 to f5e649180789 (128 revisions) flutter/packages#10452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

09a347b

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

23f423a

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

e98205f flutter_tools: correct iOS signing log for manual code signin…

bfcb247

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

e98205f flutter_tools: correct iOS signing log for manual code signin…

32ef223

…g (CODE_SIGN_STYLE=Manual) (flutter/flutter#177852)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

flutter_tools: correct iOS signing log for manual code signing (CODE_SIGN_STYLE=Manual)#177852

flutter_tools: correct iOS signing log for manual code signing (CODE_SIGN_STYLE=Manual)#177852
auto-submit[bot] merged 3 commits into
flutter:masterfrom
MohammedTarigg:fix-ios-signing-log-clean

MohammedTarigg commented Oct 31, 2025 •

edited

Loading

Uh oh!

google-cla Bot commented Oct 31, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

MohammedTarigg commented Oct 31, 2025

Uh oh!

MohammedTarigg commented Oct 31, 2025

Uh oh!

Uh oh!

vashworth commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MohammedTarigg commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What this change does

Before

After

Tests

Why this helps

Breaking Changes

Verification

Uh oh!

google-cla Bot commented Oct 31, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

MohammedTarigg commented Oct 31, 2025

Uh oh!

MohammedTarigg commented Oct 31, 2025

CI Status Follow-up

Uh oh!

Uh oh!

vashworth commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MohammedTarigg commented Oct 31, 2025 •

edited

Loading