Implement dialog windows for the Linux platform#177817
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request implements dialog windows for the Linux platform by adding new GTK FFI bindings and the DialogWindowControllerLinux class. The management of window controllers in WindowingOwnerLinux is also updated to correctly handle both regular and dialog windows. My review includes a critical fix for an issue where a dialog window cannot be correctly parented to another dialog window due to an incomplete parent lookup. Additionally, I've pointed out significant code duplication between the constructors of RegularWindowControllerLinux and the new DialogWindowControllerLinux, with a recommendation to refactor for better maintainability.
mattkae
left a comment
There was a problem hiding this comment.
LGTM aside from the comment
|
This PR is waiting on some updated platform independent tests, and will land after those are landed. |
No description provided.