Make sure that a SearchAnchor doesn't crash in 0x0 environment #177749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test case to ensure that SearchAnchor doesn't crash when it has a zero size. The test is a good addition to prevent regressions. However, the test as written is incomplete as it doesn't trigger the condition that causes the crash. I've suggested an improvement to make the test more robust by simulating the user action that opens the search view.
Comment on lines
4284
to
4298
| testWidgets('SearchAnchor does not crash at zero area', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| home: Center( | ||
| child: SizedBox.shrink( | ||
| child: SearchAnchor( | ||
| builder: (_, _) => const Text('X'), | ||
| suggestionsBuilder: (_, _) => <Widget>[const Text('Y')], | ||
| ), | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(SearchAnchor)), Size.zero); | ||
| }); |
Contributor
There was a problem hiding this comment.
The current test only verifies that a zero-sized SearchAnchor can be rendered without crashing. However, the issue this PR aims to fix (#6537) occurs when the search view is opened (e.g., by tapping the anchor). To ensure the fix is properly tested, the test should include an action to open the search view and verify it doesn't crash.1
testWidgets('SearchAnchor does not crash at zero area', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Center(
child: SizedBox.shrink(
child: SearchAnchor(
builder: (_, _) => const Text('X'),
suggestionsBuilder: (_, _) => <Widget>[const Text('Y')],
),
),
),
),
);
expect(tester.getSize(find.byType(SearchAnchor)), Size.zero);
// The crash happens when trying to open the view.
await tester.tap(find.text('X'));
await tester.pumpAndSettle();
// The test passes if it doesn't crash. We can add an assertion to be sure
// that the view is open.
expect(find.text('Y'), findsOneWidget);
});Style Guide References
Footnotes
Contributor
There was a problem hiding this comment.
I agree. Since SearchAnchor has a controller property that can open the popup programmatically, and SearchAnchor isn't implemented with MenuAnchor but is using its own layout algorithm, can you use the viewSize test template?
victorsanni
approved these changes
Oct 30, 2025
bcba8f8 to
064cd60
Compare
Contributor
|
autosubmit label was removed for flutter/flutter/177749, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Contributor
|
autosubmit label was removed for flutter/flutter/177749, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Contributor
|
autosubmit label was removed for flutter/flutter/177749, because - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/flutter/177749, because - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 22, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 22, 2025
flutter/flutter@d438df3...c8cfb2b 2025-11-22 flar@google.com Revert "[ios] Dynamic Content Resizing" (flutter/flutter#178958) 2025-11-22 ahmedsameha1@gmail.com Make sure that a SearchAnchor doesn't crash in 0x0 environment (flutter/flutter#177749) 2025-11-22 ahmedsameha1@gmail.com Make sure that a Stepper doesn't crash in 0x0 environment (flutter/flutter#178068) 2025-11-22 116356835+AbdeMohlbi@users.noreply.github.com Remove deprecated `activeColor` in `switch.0.dart` example (flutter/flutter#178293) 2025-11-22 ahmedsameha1@gmail.com Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… (flutter/flutter#178516) 2025-11-22 ahmedsameha1@gmail.com Make sure that a TimePickerDialog doesn't crash in 0x0 environment (flutter/flutter#178451) 2025-11-22 ahmedsameha1@gmail.com Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… (flutter/flutter#178566) 2025-11-22 ahmedsameha1@gmail.com Make sure that a CupertinoTabBar doesn't crash in 0x0 environment (flutter/flutter#178613) 2025-11-22 ahmedsameha1@gmail.com Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment (flutter/flutter#178722) 2025-11-22 97480502+b-luk@users.noreply.github.com Sort entries in TESTOWNERS (flutter/flutter#178939) 2025-11-22 louisehsu@google.com [ios] Dynamic Content Resizing (flutter/flutter#177410) 2025-11-21 engine-flutter-autoroll@skia.org Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) (flutter/flutter#178947) 2025-11-21 kevmoo@users.noreply.github.com Manually roll material_color_utilities (flutter/flutter#170000) 2025-11-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... (flutter/flutter#178934) 2025-11-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) (flutter/flutter#178932) 2025-11-21 engine-flutter-autoroll@skia.org Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) (flutter/flutter#178933) 2025-11-21 97480502+b-luk@users.noreply.github.com Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests (flutter/flutter#178891) 2025-11-21 15619084+vashworth@users.noreply.github.com Use interactive mode with `devicectl` to redirect stdout (flutter/flutter#178405) 2025-11-21 okorohelijah@google.com Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … (flutter/flutter#178666) 2025-11-21 engine-flutter-autoroll@skia.org Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) (flutter/flutter#178928) 2025-11-21 engine-flutter-autoroll@skia.org Roll Packages from b1e2fb0 to e67b6be (7 revisions) (flutter/flutter#178927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…er#177749) This is my attempt to handle flutter#6537 for the SearchAnchor widget. --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com> Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…er#177749) This is my attempt to handle flutter#6537 for the SearchAnchor widget. --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com> Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the SearchAnchor widget.