Make sure that a RefreshIndicator doesn't crash in 0x0 environment#177644
Merged
auto-submit[bot] merged 6 commits intoNov 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test to prevent a regression for issue #6537, where RefreshIndicator could crash in a zero-sized environment. The test correctly sets up this scenario.
My review identifies that the test is incomplete as it doesn't trigger the scrolling behavior that could cause the crash. I've provided suggestions to add a drag gesture simulation to the test and to make the ListView scrollable, making the test more comprehensive and robust for catching this kind of regression.
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(RefreshIndicator)), Size.zero); |
Contributor
There was a problem hiding this comment.
The current test only verifies that the widget can be pumped without crashing. To properly test for the crash described in issue #6537, which occurs during a scroll, a drag gesture should be simulated. This will trigger the code path that could cause a crash and ensure the fix is effective.
expect(tester.getSize(find.byType(RefreshIndicator)), Size.zero);
// Drag to trigger a scroll notification to test the drag behavior in a
// zero-sized environment, which could cause a crash.
final TestGesture gesture = await tester.startGesture(tester.getCenter(find.byType(Center)));
await gesture.moveBy(const Offset(0.0, 20.0));
await tester.pump();
await gesture.up();
await tester.pumpAndSettle();| child: SizedBox.shrink( | ||
| child: RefreshIndicator( | ||
| onRefresh: refresh, | ||
| child: ListView(children: const <Text>[Text('X')]), |
Contributor
There was a problem hiding this comment.
To ensure the ListView is scrollable even when its content fits within its (zero-sized) viewport, you should add physics: const AlwaysScrollableScrollPhysics(). This makes the test more robust for triggering scroll notifications.
Suggested change
| child: ListView(children: const <Text>[Text('X')]), | |
| child: ListView(physics: const AlwaysScrollableScrollPhysics(), children: const <Text>[Text('X')]), |
dkwingsmt
approved these changes
Nov 10, 2025
dkwingsmt
left a comment
Contributor
There was a problem hiding this comment.
LGTM. (I'm a bit surprised that this would work!)
victorsanni
approved these changes
Nov 10, 2025
Contributor
|
autosubmit label was removed for flutter/flutter/177644, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
…lutter#177644) This is my attempt to handle flutter#6537 for the RefreshIndicator widget. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…lutter#177644) This is my attempt to handle flutter#6537 for the RefreshIndicator widget. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…lutter#177644) This is my attempt to handle flutter#6537 for the RefreshIndicator widget. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the RefreshIndicator widget.