Skip to content

Fixing zoom, dropping subpixel shift#177460

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
Rusino:zooming
Nov 13, 2025
Merged

Fixing zoom, dropping subpixel shift#177460
auto-submit[bot] merged 7 commits into
flutter:masterfrom
Rusino:zooming

Conversation

@Rusino

@Rusino Rusino commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Also, fixed decoration color and the cursor in TextEditField

Part of #172561

Also, fixed decoration color and the cursor in TextEditField
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Oct 23, 2025
@Rusino Rusino self-assigned this Oct 29, 2025
@Rusino Rusino requested a review from mdebbar October 29, 2025 14:32
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/painter.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/painter.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/painter.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/test/webparagraph/paragraph_test.dart Outdated
@mdebbar mdebbar self-requested a review November 5, 2025 19:38
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paint.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paragraph.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/painter.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/painter.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paragraph.dart Outdated
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paragraph.dart Outdated
@mdebbar mdebbar marked this pull request as ready for review November 5, 2025 20:09
@Rusino Rusino requested a review from mdebbar November 6, 2025 18:55
Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paragraph.dart Outdated
@Rusino Rusino requested a review from mdebbar November 10, 2025 20:21
Comment on lines +76 to +78
void clearCanvas(ui.Rect sourceRect) {
paintContext.clearRect(0, 0, _paintCanvas.width!.ceil(), _paintCanvas.height!.ceil());
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this?

@Rusino Rusino requested a review from mdebbar November 12, 2025 22:48
@Rusino Rusino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2025
@auto-submit

auto-submit Bot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/177460, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2025
@auto-submit auto-submit Bot added this pull request to the merge queue Nov 13, 2025
Merged via the queue into flutter:master with commit 90f26f5 Nov 13, 2025
184 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
IvoneDjaja pushed a commit to IvoneDjaja/flutter that referenced this pull request Nov 22, 2025
Also, fixed decoration color and the cursor in TextEditField

Part of flutter#172561

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
Also, fixed decoration color and the cursor in TextEditField

Part of flutter#172561

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
Also, fixed decoration color and the cursor in TextEditField

Part of flutter#172561

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants