Handle the new location of Perfetto in create_updated_flutter_deps.py #177099
Conversation
Dart recently moved Perfetto to dart/third_party/perfetto/src (see https://dart.googlesource.com/sdk/+/07c9599ead52a2eea7164552e9525e3860a3aed5) This PR extends create_updated_flutter_deps to handle dependencies placed in an "src" subdirectory within the directory named for the package. It also adds a mapping for packages hosted at android.googlesource.com. (Perfetto no longer needs to be fetched from Flutter's mirror repository)
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the create_updated_flutter_deps.py script to handle the new location of the Perfetto dependency, which is now in a src subdirectory and hosted on android.googlesource.com. My review includes two main points: a suggestion to use os.path for path manipulation for better robustness and readability, and a correction to use the correct variable set (new_vars) when replacing repository URLs to ensure the script is robust against configuration differences between DEPS files.
This is an update to #177067 - see #177067 (comment) |
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
|
Landing on red to get auto-rollers unblocked (the current red tree status appears to be a flake) |
Manual roll requested by tarrinneal@google.com flutter/flutter@7cd821c...a873a27 2025-10-16 30870216+gaaclarke@users.noreply.github.com [tool] makes listing a shader also as an asset a build failure (flutter/flutter#176866) 2025-10-16 engine-flutter-autoroll@skia.org Roll Packages from d062181 to 835dccb (7 revisions) (flutter/flutter#177100) 2025-10-16 jason-simmons@users.noreply.github.com Handle the new location of Perfetto in create_updated_flutter_deps.py (flutter/flutter#177099) 2025-10-16 matt.kosarek@canonical.com Implement dialog windows for the win32 platform (flutter/flutter#176309) 2025-10-16 rmolivares@renzo-olivares.dev `SelectableRegion` should not show flutter rendered context menu when web context menu is enabled (flutter/flutter#176855) 2025-10-16 jason-simmons@users.noreply.github.com Manual roll Skia to 2d9df7c70b6f (flutter/flutter#177074) 2025-10-16 31685655+SalehTZ@users.noreply.github.com feat: add `OptionsViewOpenDirection.mostSpace` to `RawAutocomplete` (flutter/flutter#172997) 2025-10-16 43054281+camsim99@users.noreply.github.com [Android] Refactor `ImageReaderSurfaceProducer` restoration after app resumes (flutter/flutter#175937) 2025-10-15 34465683+rkishan516@users.noreply.github.com Refactor: migrate fade upwards page transition builder to widgets (flutter/flutter#175560) 2025-10-15 fluttergithubbot@gmail.com Marks Windows windowing_test to be unflaky (flutter/flutter#176701) 2025-10-15 72062416+Yash-Dhrangdhariya@users.noreply.github.com fix: 🐛 Add equality and hashCode implementations to ScrollAwareImageProvider (flutter/flutter#175038) 2025-10-15 mohellebiabdessalem@gmail.com Updates `sliver_tree.1.dart` to use `MediaQuery.widthOf(context)` (flutter/flutter#176888) 2025-10-15 mdebbar@google.com [web] Fix focus issues in newer versions of Chrome (flutter/flutter#176938) 2025-10-15 jessiewong401@gmail.com [Android 16] Update `android_engine_vulkan_tests` to Test Against SDK 36 Emulator (flutter/flutter#176985) 2025-10-15 sokolovskyi.konstantin@gmail.com Fix key events interception by RadioGroup when no Radio is focused. (flutter/flutter#176335) 2025-10-15 21270878+elliette@users.noreply.github.com Update cherry-pick instructions to include instructions for pre-release CPs (flutter/flutter#177020) 2025-10-15 jason-simmons@users.noreply.github.com Manual roll Skia to c501c727a007 (flutter/flutter#177015) 2025-10-15 robert.ancell@canonical.com Update examples to latest Linux runner style (flutter/flutter#177033) 2025-10-15 59215665+davidhicks980@users.noreply.github.com [material/menu_anchor.dart] Create internal menu controller if external controller is changed to null. (flutter/flutter#176375) 2025-10-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix - TalkBack does not announce list information (#174374)" (flutter/flutter#177062) 2025-10-14 robert.ancell@canonical.com Implement Regular Windows for Linux (flutter/flutter#176187) 2025-10-14 31510811+jwlilly@users.noreply.github.com Fix - TalkBack does not announce list information (flutter/flutter#174374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| 'engine/src/flutter/third_party/dart/third_party/devtools': | ||
| {'dep_type': 'cipd', 'packages': [{'package': 'dart/third_party/flutter/devtools', 'version': 'git_revision:0327830448901920f739259364c3f2f624df5a03'}]}, | ||
|
|
||
| 'engine/src/flutter/third_party/dart/third_party/perfetto/src': |
There was a problem hiding this comment.
We should have probably done a reverse thing: updated Dart DEPS to use flutter_git version. https://android.googlesource.com/platform/external/perfetto seems to be dead (last commit was 7 months ago), while Flutter version is tracking GitHub repo which is where development happens.
|
|
||
| plain_v = dart_k[dart_k.rfind('/') + 1:] | ||
| updated_value = updated_value.replace(new_vars["chromium_git"], "Var('chromium_git') + '") | ||
| updated_value = updated_value.replace(new_vars["android_git"], "Var('android_git') + '") |
There was a problem hiding this comment.
I don't like hardcoding specific repositories. I made a cleanup followup to address this: #177162
…flutter#177099) Dart recently moved Perfetto to dart/third_party/perfetto/src (see https://dart.googlesource.com/sdk/+/07c9599ead52a2eea7164552e9525e3860a3aed5) This PR extends create_updated_flutter_deps to handle dependencies placed in an "src" subdirectory within the directory named for the package. It also adds a mapping for packages hosted at android.googlesource.com. (Perfetto no longer needs to be fetched from Flutter's mirror repository)
Dart recently moved Perfetto to dart/third_party/perfetto/src (see https://dart.googlesource.com/sdk/+/07c9599ead52a2eea7164552e9525e3860a3aed5)
This PR extends create_updated_flutter_deps to handle dependencies placed in an "src" subdirectory within the directory named for the package.
It also adds a mapping for packages hosted at android.googlesource.com. (Perfetto no longer needs to be fetched from Flutter's mirror repository)