Remove generated file from template manifest #177034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes an entry for a generated file, templates/app/linux.tmpl/runner/my_application.cc, from template_manifest.json. As you suspected, this file is generated from my_application.cc.tmpl and does not belong in the manifest of template source files. This change makes the manifest more accurate.
Contributor
Author
|
@loic-sharma adding you as a reviewer in case you know the right person to check this. |
loic-sharma
approved these changes
Oct 24, 2025
Member
|
@bkonyi as the flutter tool tech lead would be the right reviewer, but this LGTM :) Some interesting background reading for templates manifests:
The template manifest seems to be an allowlist of files that can be used from the templates, in case the templates incorrectly have file. |
bkonyi
approved these changes
Oct 24, 2025
Contributor
|
autosubmit label was removed for flutter/flutter/177034, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Contributor
|
autosubmit label was removed for flutter/flutter/177034, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 29, 2025
flutter/flutter@7cf0dc1...df72035 2025-10-29 engine-flutter-autoroll@skia.org Roll Packages from c8ba0cc to 41c6b3d (3 revisions) (flutter/flutter#177725) 2025-10-29 43054281+camsim99@users.noreply.github.com [Android] Remove unecessary `spy` in `FlutterActivityAndFragmentDelegateTest` (flutter/flutter#177120) 2025-10-29 stuartmorgan@google.com Add discussion of federated plugin documentation (flutter/flutter#177659) 2025-10-29 mdebbar@google.com [web] Deprecate --pwa-strategy (flutter/flutter#177613) 2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from 53b8b802bbc4 to 0a0c9f8c704f (1 revision) (flutter/flutter#177701) 2025-10-29 alex.medinsh@gmail.com Add `Navigator.popUntilWithResult` (flutter/flutter#169341) 2025-10-29 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` with `withValues` in `text_style.dart` (flutter/flutter#177537) 2025-10-29 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated withOpacity in `radio.1.dart` example (flutter/flutter#177606) 2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from 4408d8ea88b0 to 53b8b802bbc4 (2 revisions) (flutter/flutter#177698) 2025-10-29 robert.ancell@canonical.com Remove generated file from template manifest (flutter/flutter#177034) 2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from e582a5594b6f to 4408d8ea88b0 (5 revisions) (flutter/flutter#177691) 2025-10-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ir6J2isKAYa1jNLyJ... to 3EF6k6lqXPWDwrdyj... (flutter/flutter#177682) 2025-10-28 jesswon@google.com [Gradle 9] Fix Engine Deps (flutter/flutter#177623) 2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `focus_scope.0.dart` example (flutter/flutter#177542) 2025-10-28 bruno.leroux@gmail.com Fix EditableText _justResumed is not accurate (flutter/flutter#177658) 2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `interactive_viewer.builder.0.dart` (flutter/flutter#177541) 2025-10-28 bruno.leroux@gmail.com Fix TextButton.icon breaks focus traversal and ink effect when toggling icon (flutter/flutter#176579) 2025-10-28 jesswon@google.com [Android 16] Update Engine `ci.yaml` to test against Java 21 (flutter/flutter#177677) 2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `interactive_viewer.constrained.0.dart` (flutter/flutter#177540) 2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace opacity from random color in navigation bar test (flutter/flutter#177490) 2025-10-28 engine-flutter-autoroll@skia.org Roll Skia from e4d3d8f31aef to e582a5594b6f (6 revisions) (flutter/flutter#177679) 2025-10-28 matej.knopp@gmail.com Workaround for lag when dragging window titlebar on Windows (flutter/flutter#177597) 2025-10-28 engine-flutter-autoroll@skia.org Roll Packages from bbf96a0 to c8ba0cc (2 revisions) (flutter/flutter#177672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
walley892
pushed a commit
to walley892/flutter
that referenced
this pull request
Oct 30, 2025
I'm not sure what this manifest is being used for but none of the other templates also list the file that is generated from them, seems to have been a typo? Co-authored-by: Ben Konyi <bkonyi@google.com>
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
I'm not sure what this manifest is being used for but none of the other templates also list the file that is generated from them, seems to have been a typo? Co-authored-by: Ben Konyi <bkonyi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what this manifest is being used for but none of the other templates also list the file that is generated from them, seems to have been a typo?