Skip to content

Fix flutter shell script to handle properly shells that have CDPATH set #17589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 1 commit into from
May 15, 2018
Merged

Fix flutter shell script to handle properly shells that have CDPATH set #17589

gspencergoog merged 1 commit into from
May 15, 2018

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 14, 2018

Before this change, if CDPATH was set, and you type (from the flutter root): bin/flutter --version

You would get an error like this:

% bin/flutter -version
bin/flutter: line 118: cd: $'./bin\n/path/to/flutter/bin': No such file or directory
Error: The Flutter directory is not a clone of the GitHub project.
       The flutter tool requires Git in order to operate properly;
       to set up Flutter, run the following command:
       git clone -b beta https://github.com/flutter/flutter.git

This is because the cd command in follow_links was printing the directory Bash chose from the CDPATH to stdout, causing the path to have a newline in it, which understandably confuses the rest of the script.

@gspencergoog gspencergoog merged commit ace2781 into flutter:master May 15, 2018
HansMuller pushed a commit that referenced this pull request May 15, 2018
Revert "Fix flutter shell script to handle properly shells that have …
a7b8d0b 
…CDPATH set (#17589)"

This reverts commit ace2781.
HansMuller pushed a commit that referenced this pull request May 15, 2018
Revert "Fix flutter shell script to handle properly shells that have …
7201415 
…CDPATH set (#17589)"

This reverts commit ace2781.
@gspencergoog gspencergoog deleted the flutter_cdpath branch May 30, 2018 21:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gspencergoog @tvolkert @googlebot