Add the ability to limit Draggables to a single axis #17587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
May 15, 2018
| /// than in a scroll because the draggable widget, being the more specific | ||
| /// widget, will out-compete the [Scrollable] for vertical gestures. | ||
| /// | ||
| /// |
Contributor
There was a problem hiding this comment.
remove one extra blank line here
Hixie
reviewed
May 15, 2018
| return velocity; | ||
| } | ||
| return new Velocity( | ||
| pixelsPerSecond: _restrictAxis(velocity.pixelsPerSecond)); |
Contributor
There was a problem hiding this comment.
put this all on one line or put a comma after the first ) so that the next one ends up on the next line.
Hixie
reviewed
May 15, 2018
| Offset _restrictAxis(Offset offset) { | ||
| if (axis == null) { | ||
| return offset; | ||
| } else if (axis == Axis.horizontal) { |
Contributor
There was a problem hiding this comment.
you can omit the else if you have a return in the previous block.
Contributor
|
|
HansMuller
pushed a commit
that referenced
this pull request
May 15, 2018
This reverts commit 5159ab3.
HansMuller
pushed a commit
that referenced
this pull request
May 15, 2018
This reverts commit 5159ab3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of solving #16763.
This adds a new field to the Draggable API: axis. Behavior covered in the DartDoc, but setting it limits the underlying _DragAvatar's motion to the assigned axis. When axis is null, the behavior is the same as before. As a result, this won't break anything.