Updates to debugDisableShadows #17577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make BoxShadow.toPaint() add a stroke so that we can see where shadows would have otherwise been painted. 2. Make CupertinoSwitch use BoxShadow.toPaint() so that it respects the `debugDisableShadows` flag.
tvolkert
added a commit
to flutter/goldens
that referenced
this pull request
May 14, 2018
Code changes in flutter/flutter#17577
Hixie
reviewed
May 14, 2018
| new Radius.circular(rect.shortestSide / 2.0), | ||
| ); | ||
|
|
||
| final Paint shadowPaint = new BoxShadow( |
Contributor
There was a problem hiding this comment.
let's create that in the constructor
Contributor
Author
There was a problem hiding this comment.
Weird - hadn't seen this before. Done.
Hixie
reviewed
May 14, 2018
| result.maskFilter = null; | ||
| if (debugDisableShadows) { | ||
| result | ||
| ..maskFilter = null; |
Contributor
There was a problem hiding this comment.
i assume you meant to revert this :-)
Hixie
reviewed
May 15, 2018
| final Color shadowColor; | ||
|
|
||
| /// The paint used to draw the shadow case by the thumb. | ||
| Paint _shadowPaint; |
Contributor
There was a problem hiding this comment.
this can be final if you set it in the constructor initialiser list
Contributor
|
|
Contributor
Author
|
Merging on red because the redness is a suspected flake that we're unable to restart. |
HansMuller
pushed a commit
that referenced
this pull request
May 15, 2018
This reverts commit c4cb0ec.
HansMuller
pushed a commit
that referenced
this pull request
May 15, 2018
This reverts commit c4cb0ec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shadows would have otherwise been painted.
the
debugDisableShadowsflag.