Refactor Predicate.java to address linter issues
#175278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
reviewed
Sep 15, 2025
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
What is interesting here is that the 24 is currently the min api. @AbdeMohlbi want to try removing this interface altogether since the comment indicates it is no longer needed?
Contributor
Author
|
yeah as it seems that one manifest file was suppresing all the linter issues and now they all appeared :/ |
Contributor
Author
|
yeah sorry i don't have the mental capacity to fix all the linter issues but still thank u @reidbaker |
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Relands #175278 this PR bumps used minSdk version in the `engine` to `24` . ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] All existing and new tests are passing. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Signed-off-by: jwlilly <lilly.john.w@gmail.com> Signed-off-by: huycozy <huy@nevercode.io> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com> Co-authored-by: Abdelaziz Mahdy <zezohassam@gmail.com> Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com> Co-authored-by: Ben Konyi <bkonyi@google.com> Co-authored-by: Flop <38378650+hgraceb@users.noreply.github.com> Co-authored-by: Victor Sanni <victorsanniay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Co-authored-by: Slava Egorov <vegorov@google.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Elijah Okoroh <okorohelijah@google.com> Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: zhongliugo <zhongliu88889@gmail.com> Co-authored-by: auto-submit[bot] <98614782+auto-submit[bot]@users.noreply.github.com> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Felipe Peter <mr-peipei@web.de> Co-authored-by: Daco Harkes <dacoharkes@google.com> Co-authored-by: Ahmed Mohamed Sameh <ahmedsameha1@gmail.com> Co-authored-by: Simon Binder <simon@journeyapps.com> Co-authored-by: ANUJ KUMAR <77888283+shivanuj13@users.noreply.github.com> Co-authored-by: anuj.kumar <anuj.kumar@powerup.money> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Pierre <6655696+guidezpl@users.noreply.github.com> Co-authored-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Pierre-Louis <plg@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: bungeman <bungeman@chromium.org> Co-authored-by: jesswrd <jesswon@google.com> Co-authored-by: John Lilly <31510811+jwlilly@users.noreply.github.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: b-luk <97480502+b-luk@users.noreply.github.com> Co-authored-by: flutter-pub-roller-bot <137456488+flutter-pub-roller-bot@users.noreply.github.com> Co-authored-by: Michel Feinstein <feinstein@users.noreply.github.com> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Tess Strickland <sstrickl@google.com> Co-authored-by: Huy <huy@nevercode.io> Co-authored-by: Kostia Sokolovskyi <sokolovskyi.konstantin@gmail.com> Co-authored-by: LouiseHsu <louisehsu@google.com> Co-authored-by: Mouad Debbar <mdebbar@google.com> Co-authored-by: Tim Maffett <timmaffett@gmail.com> Co-authored-by: Aaron Clarke <aaclarke@google.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Nebojša Cvetković <nebkat@gmail.com> Co-authored-by: Tirth <pateltirth454@gmail.com> Co-authored-by: Ivan Inozemtsev <iinozemtsev@google.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Jon Ihlas <jon.i@hotmail.fr> Co-authored-by: Robert Ancell <robert.ancell@canonical.com> Co-authored-by: Harry Terkelsen <1961493+harryterkelsen@users.noreply.github.com> Co-authored-by: Jackson Gardner <jacksongardner@google.com> Co-authored-by: Jim Graham <flar@google.com> Co-authored-by: DoLT <dolt@guide.inc> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: John "codefu" McDole <codefu@google.com> Co-authored-by: Dev TtangKong <ttankkeo112@gmail.com> Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Matt Boetger <matt.boetger@gmail.com> Co-authored-by: Kaylee Lubick <kjlubick@users.noreply.github.com> Co-authored-by: Ramon Farizel <45459898+RamonFarizel@users.noreply.github.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Lau Ching Jun <chingjun@google.com> Co-authored-by: Rusino <Rusino@users.noreply.github.com> Co-authored-by: Reid Baker <reidbaker@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.