-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[docs] Add initial version of Flutter AI rules #175011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an initial set of AI rules for Flutter development in a new docs/rules directory. The rules are well-structured and cover many aspects of Flutter development, from project setup to visual design. My review focuses on improving the clarity and consistency of these rules to ensure the AI can interpret them correctly. I've pointed out a contradiction in the state management guidance and suggested a clarification. I also found an unclear rule regarding image assets and proposed a more specific and actionable version.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@gspencergoog @sethladd I think I've addressed most of the feedback that makes sense as per our conversation today. Please take another look and let me know if you have any questions, thanks! |
|
LGTM from my side, thank you. I assume we can keep tweaking in later PRs |
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request is not mergeable
This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules cc: @sethladd @rodydavis --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
flutter/flutter@8d0b31d...8f94cb0 2025-09-17 mohellebiabdessalem@gmail.com fix typo in comments to mention `settings.gradle/.kts` instead of `build.gradle/.kts` (flutter/flutter#175486) 2025-09-17 mohellebiabdessalem@gmail.com replace ` Charset.forName("UTF-8")` with `StandardCharsets.UTF_8` to address linter issues (flutter/flutter#175275) 2025-09-17 engine-flutter-autoroll@skia.org Roll Skia from 283a8ff3bca5 to a5a8f1df14bb (6 revisions) (flutter/flutter#175512) 2025-09-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 649eef6040a1 to 116f7fe72839 (3 revisions) (flutter/flutter#175474) 2025-09-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wzk_HjPLGu-mlg5hC... to 0_jKqLGnkILvQ5C8a... (flutter/flutter#175468) 2025-09-16 34871572+gmackall@users.noreply.github.com Sync 3.35.3 and 3.35.4 notes from stable to master (flutter/flutter#175461) 2025-09-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 700de52f29a9 to 649eef6040a1 (4 revisions) (flutter/flutter#175455) 2025-09-16 mohellebiabdessalem@gmail.com Update gradle_errors.dart to use constants defined in gradle_utils.dart (flutter/flutter#174760) 2025-09-16 mohellebiabdessalem@gmail.com Update gradle_utils.dart to use `constant` instead of `final` (flutter/flutter#175443) 2025-09-16 mohellebiabdessalem@gmail.com fix typo in test documentation (flutter/flutter#174292) 2025-09-16 1961493+harryterkelsen@users.noreply.github.com [benchmarks] Allow passing --local-web-sdk and --build-mode flags to benchmarks (flutter/flutter#175199) 2025-09-16 34871572+gmackall@users.noreply.github.com Roll pub packages and update lockfiles (flutter/flutter#175446) 2025-09-16 ryjohn@google.com [docs] Add initial version of Flutter AI rules (flutter/flutter#175011) 2025-09-16 mohellebiabdessalem@gmail.com Remove redundant `public` modifier for interface members in MouseCursorPlugin.java (flutter/flutter#175281) 2025-09-16 mohellebiabdessalem@gmail.com Remove the unnecessary semicolon at the end of the line in `ProcessTextPlugin.java` (flutter/flutter#175280) 2025-09-16 mohellebiabdessalem@gmail.com Remove unnecessary `toString()` call in `ImageReaderPlatformViewRenderTarget.java` (flutter/flutter#175286) 2025-09-16 mohellebiabdessalem@gmail.com Refactor `AccessibilityBridge.java` to address linter issues (flutter/flutter#175277) 2025-09-16 mohellebiabdessalem@gmail.com Replace `.size() == 0` with `isEmpty()` in `PlatformPlugin.java` (flutter/flutter#175285) 2025-09-16 dkwingsmt@users.noreply.github.com Allow Passing an AnimationController to CircularProgressIndicator and LinearProgressIndicator (flutter/flutter#174605) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 7d160bbf9403 to 283a8ff3bca5 (11 revisions) (flutter/flutter#175436) 2025-09-16 codefu@google.com chore: move engine docs out of engine/ and into docs/ (flutter/flutter#175195) 2025-09-16 jason-simmons@users.noreply.github.com [Impeller] Disable the render target cache when creating a snapshot in DlImageImpeller::MakeFromYUVTextures (flutter/flutter#174912) 2025-09-16 mohellebiabdessalem@gmail.com Remove redundant public modifier in `PlatformViewRenderTarget.java` (flutter/flutter#175284) 2025-09-16 jessiewong401@gmail.com Update NDK to The Latest Stable (flutter/flutter#175365) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules cc: @sethladd @rodydavis --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules cc: @sethladd @rodydavis --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules cc: @sethladd @rodydavis --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules
cc: @sethladd @rodydavis