Skip to content

[3.35] Do not include :unittests unless enable_unittests#173734

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.35-candidate.0from
flutteractionsbot:cp-beta-446adb1acc5f07d065954bc6028a8dd2390cd68f
Aug 13, 2025
Merged

[3.35] Do not include :unittests unless enable_unittests#173734
auto-submit[bot] merged 1 commit into
flutter:flutter-3.35-candidate.0from
flutteractionsbot:cp-beta-446adb1acc5f07d065954bc6028a8dd2390cd68f

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#173728

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

N/A

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Skips building Android unit tests during the engine release builder

Workaround:

Is there a workaround for this issue?

No

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

The release builder step works.

Closes flutter#173728.

This will need to be cherrypicked into both 3.35 and 3.36.
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Aug 13, 2025
@flutteractionsbot

Copy link
Copy Markdown
Contributor Author

@matanlurey please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Aug 13, 2025
gemini-code-assist[bot]

This comment was marked as off-topic.

@matanlurey matanlurey changed the title [CP-beta]Do not include :unittests unless enable_unittests [3.35] Do not include :unittests unless enable_unittests Aug 13, 2025
@matanlurey matanlurey requested a review from camsim99 August 13, 2025 21:40
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025
@auto-submit

auto-submit Bot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/173734, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025
auto-submit Bot pushed a commit that referenced this pull request Aug 13, 2025
@auto-submit auto-submit Bot merged commit 1e9a811 into flutter:flutter-3.35-candidate.0 Aug 13, 2025
163 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants