Release thread-local resources when submitting a Flutter GPU command buffer #173663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buffer Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful. Fixes flutter#172068
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a call to DisposeThreadLocalCachedResources after submitting a command buffer. This is intended to release thread-local resources, like Vulkan command pools, once they are no longer needed for the current set of operations. The change is applied to both the OpenGL ES backend path (which submits asynchronously on the raster thread) and the synchronous path for other backends.
The change is correct and addresses the issue described. I have one suggestion to improve error handling in the asynchronous path to make it more robust and consistent with the synchronous path.
Comment on lines
+56
to
+57
| context->GetCommandQueue()->Submit({command_buffer}, | ||
| completion_callback); |
Contributor
There was a problem hiding this comment.
The Submit call returns an fml::Status which is currently being ignored. This could hide potential submission failures. It's better to handle the status, for example by logging an error on failure. This will also make the behavior consistent with the other path in this function where the status is checked.1
auto status = context->GetCommandQueue()->Submit(
{command_buffer}, completion_callback);
if (!status.ok()) {
FML_LOG(ERROR) << "Failed to submit command buffer: " << status;
}Style Guide References
Footnotes
chinmaygarde
approved these changes
Aug 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 26, 2025
flutter/flutter@a4cb00a...c65f01d 2025-08-26 engine-flutter-autoroll@skia.org Roll Packages from fe66130 to 1ef712e (4 revisions) (flutter/flutter#174442) 2025-08-26 15619084+vashworth@users.noreply.github.com Revert "Directly generate a Mach-O dynamic library using gen_snapshot (#171626) (flutter/flutter#174392) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 5.4.0 to 5.5.0 in the all-github-actions group (flutter/flutter#174436) 2025-08-26 engine-flutter-autoroll@skia.org Roll Skia from 9daab16abbf9 to 21214d63fc40 (1 revision) (flutter/flutter#174431) 2025-08-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UiY8gj468PZUj6QTm... to L5zGzsIWIS8N36AFQ... (flutter/flutter#174430) 2025-08-26 engine-flutter-autoroll@skia.org Roll Dart SDK from f1f90d413dd3 to 9054cd8af73c (2 revisions) (flutter/flutter#174428) 2025-08-26 engine-flutter-autoroll@skia.org Roll Skia from afb5c22d9ba0 to 9daab16abbf9 (2 revisions) (flutter/flutter#174429) 2025-08-26 engine-flutter-autoroll@skia.org Roll Skia from 2227187dbdcf to afb5c22d9ba0 (1 revision) (flutter/flutter#174425) 2025-08-26 87506348+jingshao-code@users.noreply.github.com [iOS][Secure Paste] Custom edit menu actions (flutter/flutter#171825) 2025-08-26 huy@nevercode.io Make SystemUiOverlayStyle to be diagnosticable (flutter/flutter#174018) 2025-08-26 34465683+rkishan516@users.noreply.github.com Fix: Active step fully colored in vertical mode (flutter/flutter#173152) 2025-08-26 32538273+ValentinVignal@users.noreply.github.com Migrate to use `WidgetStateProperty` (flutter/flutter#174323) 2025-08-26 engine-flutter-autoroll@skia.org Roll Skia from ed42a94ee066 to 2227187dbdcf (3 revisions) (flutter/flutter#174417) 2025-08-26 engine-flutter-autoroll@skia.org Roll Dart SDK from a0e39d9b4a58 to f1f90d413dd3 (1 revision) (flutter/flutter#174409) 2025-08-26 jason-simmons@users.noreply.github.com [Impeller] Flush the data written to the device buffer by RoundSuperellipseGeometry (flutter/flutter#174316) 2025-08-26 flar@google.com Remove obsolete vulkan_window source files (flutter/flutter#174087) 2025-08-25 1961493+harryterkelsen@users.noreply.github.com [web] Migrate non-CanvasKit-specific tests to ui/ (flutter/flutter#174396) 2025-08-25 jessy.yameogo@gmail.com Create Hot Restart over websocket test (flutter/flutter#173852) 2025-08-25 engine-flutter-autoroll@skia.org Roll Dart SDK from e283a9e88242 to a0e39d9b4a58 (1 revision) (flutter/flutter#174383) 2025-08-25 matanlurey@users.noreply.github.com Update `master` CHANGELOG for 3.35.2 (flutter/flutter#174399) 2025-08-25 engine-flutter-autoroll@skia.org Roll Skia from da724d312e65 to ed42a94ee066 (4 revisions) (flutter/flutter#174394) 2025-08-25 58529443+srujzs@users.noreply.github.com Update dwds to 25.0.3 (flutter/flutter#174379) 2025-08-25 38427679+xVemu@users.noreply.github.com Fix logic statements in year2023 documentation (flutter/flutter#174120) 2025-08-25 jason-simmons@users.noreply.github.com Release thread-local resources when submitting a Flutter GPU command buffer (flutter/flutter#173663) 2025-08-25 1961493+harryterkelsen@users.noreply.github.com [web] Refactor LayerScene out of CanvasKit (flutter/flutter#174375) 2025-08-25 15619084+vashworth@users.noreply.github.com Stream logs from `devicectl` and `lldb` (flutter/flutter#173724) 2025-08-25 jmccandless@google.com NavigatorPopScope examples no longer use deprecated onPop. (flutter/flutter#174291) 2025-08-25 mohellebiabdessalem@gmail.com fix typo in test documentation function name (flutter/flutter#174297) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…buffer (flutter#173663) Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful. Fixes flutter#172068
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…buffer (flutter#173663) Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful. Fixes flutter#172068
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…buffer (flutter#173663) Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful. Fixes flutter#172068
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…buffer (flutter#173663) Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful. Fixes flutter#172068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impeller back ends may hold resources (such as Vulkan command pools) in thread-local storage so they can be reused during a series of operations. These resources must be freed when they are no longer useful.
Fixes #172068