Skip to content

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Aug 6, 2025

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@justinmc justinmc self-assigned this Aug 6, 2025
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong, but you might need to actually change this to 659d9553df45256ed2aa388aae7ed5a1a4f51bae. The issue is that 01534568db3fba0ecd17442e3cf1c4ba1181b7de doesn't actually change the engine tree at all, so you may end up failing CI when you try to do the actual release.

You can run bin/internal/last_engine_commit.sh to see what the CI tooling is going to expect the engine.version to be.

@justinmc
Copy link
Contributor Author

justinmc commented Aug 7, 2025

Done, thank you for catching that! I'm making some notes to update the docs on this with more details.

@justinmc justinmc requested a review from eyebrowsoffire August 7, 2025 18:32
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025
@auto-submit auto-submit bot merged commit 9122761 into flutter:flutter-3.35-candidate.0 Aug 7, 2025
5 checks passed
@justinmc justinmc deleted the beta-3.35-3-engine-version branch August 7, 2025 20:32
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants