-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update engine version for 3.35-.03 #173371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update engine version for 3.35-.03 #173371
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
reidbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but you might need to actually change this to 659d9553df45256ed2aa388aae7ed5a1a4f51bae. The issue is that 01534568db3fba0ecd17442e3cf1c4ba1181b7de doesn't actually change the engine tree at all, so you may end up failing CI when you try to do the actual release.
You can run bin/internal/last_engine_commit.sh to see what the CI tooling is going to expect the engine.version to be.
|
Done, thank you for catching that! I'm making some notes to update the docs on this with more details. |
9122761
into
flutter:flutter-3.35-candidate.0
Picks up two beta cherry picks: https://github.com/flutter/flutter/commits/flutter-3.35-candidate.0/
#173304
#173072