Make sure that a Checkbox doesn't crash in 0x0 environment #173178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable regression test to ensure that a Checkbox does not crash when rendered in a zero-sized environment, as reported in issue #6537. The test case is well-structured and accurately captures the failure condition. However, the pull request seems to be missing the actual fix for the underlying issue in the Checkbox widget's implementation. Without the fix, this new test is expected to fail, preventing the PR from being merged. The author should add the necessary code changes to resolve the crash.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 9, 2025
flutter/flutter@3821790...1590543 2025-08-09 jessy.yameogo@gmail.com Make device debuggable if useDwdsWebSocketConnection is true and added simple test case (flutter/flutter#171648) 2025-08-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 91cbf6d7563a to 6a7ae1ffd1c9 (1 revision) (flutter/flutter#173487) 2025-08-09 41930132+hellohuanlin@users.noreply.github.com add `--variance host_debug_unopt_arm64` for apple chip simulator (flutter/flutter#173475) 2025-08-08 mdebbar@google.com [WebParagraph] Fix a property name on newer Chrome versions (flutter/flutter#173477) 2025-08-08 ahmedsameha1@gmail.com Make sure that a Checkbox doesn't crash in 0x0 environment (flutter/flutter#173178) 2025-08-08 ahmedsameha1@gmail.com Make sure that a RawChip doesn't crash in 0x0 environment (flutter/flutter#173265) 2025-08-08 victorsanniay@gmail.com Fix tooltip crash when route has secondary animation (flutter/flutter#172678) 2025-08-08 engine-flutter-autoroll@skia.org Roll Skia from 86824ed582be to 44bb9d908ee4 (3 revisions) (flutter/flutter#173476) 2025-08-08 matt.boetger@gmail.com Fix null value reference in `flutter logs` path (flutter/flutter#173437) 2025-08-08 1063596+reidbaker@users.noreply.github.com Remove jetifier usages from framework and engine (flutter/flutter#173459) 2025-08-08 jhy03261997@gmail.com [a11y] Textfield has flag `isFocusable` set to true (flutter/flutter#173235) 2025-08-08 engine-flutter-autoroll@skia.org Roll Dart SDK from 4b7b565eb468 to 91cbf6d7563a (1 revision) (flutter/flutter#173469) 2025-08-08 engine-flutter-autoroll@skia.org Roll Packages from 6efb759 to 34948d1 (4 revisions) (flutter/flutter#173470) 2025-08-08 engine-flutter-autoroll@skia.org Roll Skia from a6ccfeafbfba to 86824ed582be (20 revisions) (flutter/flutter#173468) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 11, 2025
…73178) This is my attempt to handle flutter#6537 for the Checkbox UI control.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…73178) This is my attempt to handle flutter#6537 for the Checkbox UI control.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…73178) This is my attempt to handle flutter#6537 for the Checkbox UI control.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…73178) This is my attempt to handle flutter#6537 for the Checkbox UI control.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…73178) This is my attempt to handle flutter#6537 for the Checkbox UI control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Checkbox UI control.