Update engine version for 3.35-0.2.pre#172987
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| @@ -1 +1 @@ | |||
| 1c9c20e7c3dd48c66f400a24d48ea806b4ab312a | |||
| cc968cae8b35cd4761a7bd405110ec1523a43844 | |||
There was a problem hiding this comment.
You're right! I think I ran last_engine_commit.sh before pulling
4532109 to
20688ab
Compare
| @@ -1 +1 @@ | |||
| 1c9c20e7c3dd48c66f400a24d48ea806b4ab312a | |||
| 789c3e343156c5942796b0ea59c50096f138396b | |||
There was a problem hiding this comment.
That commit didn't modify the engine, so I think we'd run into issues if we used it.
There was a problem hiding this comment.
Because that commit doesn't modify the engine. I verified that last_engine_commit.sh still outputs 789c3e343156c5942796b0ea59c50096f138396b even on that commit itself.
There was a problem hiding this comment.
I dont think that is true I think we can use literally any commit. @jtmcdole do you know the technical limitations?
There was a problem hiding this comment.
maybe I got lucky last week when I just picked the last commit.
There was a problem hiding this comment.
I think this changed a few releases ago. Maybe you got lucky with this most recent release. I've had ones in the past where I pinned to the latest commit and CI failed me because that commit didn't have engine changes.
f32d84f
into
flutter:flutter-3.35-candidate.0
No description provided.