[CP-beta][ios]update provisioning profile for 2025-2026 cert for chromium bots#172972
Conversation
…flutter#171021) This updates provisioning profile mainly for chromium bots. Some devicelab tests also use this profile, according to flutter#155101. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* flutter#168427 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
|
@vashworth please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the apple_signing dependency version to to_2026 in .ci.yaml to use a newer certificate, which is a straightforward and necessary change.
However, the pull request description is currently a placeholder template. This is a high-priority issue that blocks this PR's approval. Please fill out all sections of the description, including the original issue link, a changelog description, impact, and validation steps, as required by the project's contribution guidelines. This information is essential for reviewers to assess the change and for maintaining a clear history.
I have also left one medium-severity comment regarding configuration duplication in .ci.yaml, which should be considered for future improvements to maintainability.
| dependencies: >- | ||
| [ | ||
| {"dependency": "apple_signing", "version": "version:to_2025"} | ||
| {"dependency": "apple_signing", "version": "version:to_2026"} |
There was a problem hiding this comment.
This version string version:to_2026 is repeated 7 times in this file. This duplication violates the style guide's principle to 'Avoid duplicating state'1 and creates a maintenance burden for future updates. An instance could easily be missed during the next update cycle.
While a larger refactoring might be out of scope for this cherry-pick, please consider investigating if the CI system supports YAML anchors or variables for future changes. Centralizing this value would make updates simpler and less error-prone.
Style Guide References
Footnotes
def9ff9
into
flutter:flutter-3.35-candidate.0
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#168427
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Updates the provisioning profile that Flutter's CI uses.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
This only impacts the release team. Without this patch, codesigning on try and prod chromium bots will fail.
Workaround:
Is there a workaround for this issue?
No
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run a test that requires codesigning, such as "Mac_x64 tool_host_cross_arch_tests"