[web] Listen to text spacing overrides by Renzo-Olivares · Pull Request #172915 · flutter/flutter

Renzo-Olivares · 2025-07-29T19:41:26Z

Framework:

EditableText/SelectableText, applies lineHeightScaleFactorOverride, wordSpacingOverride, and letterSpacingOverride to it's TextStyle similarly to how we already do for bold platform overrides. Note SelectableText is built on EditableText so it also applies these overrides.
Text, applies lineHeightScaleFactorOverride, wordSpacingOverride, and letterSpacingOverride to it's TextStyle similarly to how we already do for bold platform overrides.
Exposes line height override through MediaQueryData.lineHeightScaleFactorOverride and maybeLineHeightScaleFactorOverrideOf(context).
Exposes letter spacing override through MediaQueryData.letterSpacingOverride and maybeLetterSpacingOverrideOf(context).
Exposes word spacing override through MediaQueryData.wordSpacingOverride and maybeWordSpacingOverrideOf(context).
Exposes paragraph spacing override through MediaQueryData.paragraphSpacingOverride and maybeParagraphSpacingOf(context).

Engine:

Introduces new members on PlatformDispatcher API that hold the text spacing properties that are overridden on the web.
We provide the lineHeightScaleFactorOverride, letterSpacingOverride, wordSpacingOverride, and paragraphSpacingOverride on the web by attaching a ResizeObserver to an off-screen hidden element, when its size changes we capture its text spacing CSS properties, and notify the framework through onMetricsChanged.

Fixes #142712

Screen.Recording.2025-07-30.at.2.50.37.PM.mov

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request introduces support for platform typography settings on the web, allowing Flutter apps to respect user-defined text spacing for properties like line height, letter spacing, and word spacing. The changes are well-structured, adding a TypographySettings class and plumbing it through the platform dispatcher and MediaQuery. My main feedback is on the web implementation of the DomMutationObserver, which has some robustness issues in detecting style changes. I've provided a suggestion to make it more reliable.

Renzo-Olivares · 2025-08-07T23:54:17Z

+          return;
+        }
+        // Disable text spacing properties.
+        _updateTypographySettings(const ui.TypographySettings());


I'm not a fan of setting this to an empty TypographySettings to disable this but I don't see another way since configuration.copyWith(typographySettings:null) won't work. I could build a method that makes a new PlatformConfiguration with TypographySettings cleared but it wouldn't be very maintainable if we keep adding members to PlatformConfiguration.

I vaguely remember somewhere we do something like

void copyWith({SomeClass? object = _somePivateStaticObject}) { if (object != _somePivateStaticObject) { // do replace } }

is assigning typographySettings an empty TypographySettings or null the same thing? if so we should only pick one of them to avoid this ambiguous. For example just make typographySettings to be not nullable and default to a static/const empty value.

Renzo-Olivares · 2025-08-07T23:56:08Z

+  });
+
+  /// The height of the text, as a multiple of the font size.
+  final double? lineHeight;


Should this be lineHeightFactor instead? It seems like a more appropriate name.

In CSS line-height can accept:

Default: normal

Normal keyword

Unitless, relative to font size, for example 2.

<length>, number followed by units 10px

<percentage>, number followed by % sign 10%, relative to font size

but there seems to be a strong preference for unitless numbers, i.e. numbers relative to font size.

https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values

In the extension and bookmarklet I tried both are using unitless values for their CSS.

Do we need to support other type of unit? If so, can a double support both unitless and px ?

IMO it doesn't make sense to set line height to an absolute number for a11y purposes. Percentage makes sense but it's basically the same as unitless, i.e. 150% == 1.5.

I think double can support unitless and px, from what I understand and my observations getComputedStyle will return px values, for word-spacing, letter-spacing, and margin-bottom we can use these 1:1 for their framework counter parts TextStyle.wordSpacing, TextStyle.letterSpacing, and Padding. For line-height we can divide it by the font size and get the lineHeightFactor which would be 1:1 with the frameworks TextStyle.height. So lineHeight would be a factor of fontSize, similar to the frameworks representation.

Renzo-Olivares · 2025-08-08T18:57:06Z

      );
    }
+    if (typographySettings != null && typographySettings.paragraphSpacing != null) {
+      result = Padding(


I'm curious to hear people's thoughts about implementing paragraphSpacing like this. On the web the extension and bookmarklet i've been using implement it by using margin-bottom on the p element.

I think gpay has internal code that turns html into TextSpans

Interesting, if they're converting for example <p> elements into TextSpans with the expectation that those <p> elements have paragraphSpacing applied to them, then that will likely not work. They would have to instead turn <p> elements into Text widgets for that expectation to be true.

chunhtai

applies paragraph spacing (margin-bottom) by wrapping its contents with a bottom Padding.

Will this handle cases where developer use \n\n to generate paragraph within a single text widget? or is this something that we don't care about?

chunhtai · 2025-08-14T16:32:45Z

+  });
+
+  /// The height of the text, as a multiple of the font size.
+  final double? lineHeight;


Do we need to support other type of unit? If so, can a double support both unitless and px ?

chunhtai · 2025-08-14T16:47:53Z

+          return;
+        }
+        // Disable text spacing properties.
+        _updateTypographySettings(const ui.TypographySettings());


I vaguely remember somewhere we do something like

void copyWith({SomeClass? object = _somePivateStaticObject}) { if (object != _somePivateStaticObject) { // do replace } }

is assigning typographySettings an empty TypographySettings or null the same thing? if so we should only pick one of them to avoid this ambiguous. For example just make typographySettings to be not nullable and default to a static/const empty value.

chunhtai · 2025-08-14T17:06:23Z

+      autofillHints: null,
+      contextMenuBuilder: widget.contextMenuBuilder,
    );
+    final ui.TypographySettings? typographySettings = MediaQuery.maybeTypographySettingsOf(context);


Not something that blocks this pr

I noticed we start to put more and more text related settings into MediaQuery, but we also have DefaultTextStyle. What are the guideline to decide whether something should be in one vs the other?

Good point, I feel like this feature is sort of outside the scope of DefaultTextStyle. I think of DefaultTextStyle as a configuration provider that is set up by the application developer, TypographySettings is a configuration set up by the user, and cannot really be updated on the application developers end. So maybe DefaultTextStyle should only include app level configuration, while MediaQuery/TypographySettings includes user level configurations. What do you think about this? I think text scale factor and maybe bolt text would be in line with the type of settings included in TypographySettings.

What if one day they start to have overlaps? for example, if one day Android let's user to set the system wide font style. Do we duplicate both in DefaultTextStyle and mediaQuery?

In this case it feels like it would still be important to distinguish between application level configuration and system wide configuration in the case one is preferred over the other. It also feels like this type of system setting is unlikely to exposed because it is a setting that would affect many other apps as well, so the overlap might not be something we have to consider.

MediaQuery should be considered application level configuration. It is just by default Material app will inherited system level configuration into default MediaQuery. The developer can still override them if they want.

I guess my question is why don't we put TextStyle direclty in MediaQuery to carry the things like text space, or let TextStyle carry a TypographySettings as its property and remove the text spacing, line high...etc.

I don't have enough context to make a suggestion on which paradigm is better, so it is your call. I am just feel a bit confused at how we structure these settings in different part of widget tree. For example. system provides a,b,c,d all meant for Text-related widget.

when it reaches mediaquery, it bundles (a,b) into a class so it carries (a,b), c, d.

but when it reach widget it unwrap and re-bundled b and c, and it becomes a, (b, c), d.

It is a bit hard to wrap my head around these logical data class in each layer

Thank you for the clarification, I think I understand your concerns better. As a user it is strange that different text settings are spread across MediaQuery instead of consolidated in one.

In the current state a user needs to pull three members from MediaQuery and apply them across 2 different classes with majority being in TextStyle:

TypographySettings - applies to TextStyle, and Padding widget.

boldText - applies to TextStyle.

textScaler - applies to TextStyle.

it would make sense if a user only had to pull one member from MediaQuery to access text related settings.

final ui.TypographySettings? typographySettings = MediaQuery.maybeTypographySettingsOf(context); effectiveTextStyle = effectiveTextStyle!.merge( TextStyle( height: typographySettings?.lineHeight,//a letterSpacing: typographySettings?.letterSpacing,//b wordSpacing: typographySettings?.wordSpacing,//c fontWeight: MediaQuery.boldTextOf(context) ? FontWeight.bold : null,//d ), ); if (typographySettings != null && typographySettings.paragraphSpacing != null) { result = Padding( padding: EdgeInsets.only(bottom: typographySettings.paragraphSpacing!),//e child: result, ); }

(I'm loving this excellent discussion!)

I think what Chun-Heng is suggesting is putting all TypographySettings on MediaQueryData directly.

Something like:

final double? lineScaleFactor = MediaQuery.lineScaleFactorOf(context); final double? letterSpacing = MediaQuery.letterSpacingOf(context); final double? wordSpacing = MediaQuery.wordSpacingOf(context); final double? paragraphSpacing = MediaQuery.paragraphSpacingOf(context); final FontWeight? fontWeight = MediaQuery.boldTextOf(context) ? FontWeight.bold : null; if (lineScaleFactor != null || letterSpacing != null || ... ) { effectiveTextStyle = effectiveTextStyle!.merge( TextStyle( height: lineScaleFactor,//a letterSpacing: letterSpacing,//b wordSpacing: wordSpacing,//c fontWeight: fontWeight,//d ), ); if (paragraphSpacing != null) { result = Padding( padding: EdgeInsets.only(bottom: paragraphSpacing!),//e child: result, ); }

This API does seem more consistent to me.

Thank you for the API suggestions @loic-sharma! I agree putting the settings directly on MediaQueryData looks more clean and consistent.

yup that sounds good to me.

Yes I was suggesting two extreme, this or bundle all text related property in on class, anything in between seems weird. Since MediaQuery has been going with putting everything directly in mediaQuery. so I think the safest for now is to go with the current pattern. we can revisit it later if we want to change that and bundle every thing together in the furture

chunhtai · 2025-08-14T17:12:38Z

  ///    supported.
  final bool supportsShowingSystemContextMenu;

+  /// The typography settings for the view this media query is derived from.


Maybe,

The user's preferred typography settings.

chunhtai · 2025-08-14T17:22:38Z

      );
    }
+    if (typographySettings != null && typographySettings.paragraphSpacing != null) {
+      result = Padding(


I think gpay has internal code that turns html into TextSpans

Renzo-Olivares · 2025-08-14T19:08:17Z

applies paragraph spacing (margin-bottom) by wrapping its contents with a bottom Padding.

Will this handle cases where developer use \n\n to generate paragraph within a single text widget? or is this something that we don't care about?

I want to say we don't really care about that case since the web doesn't seem to properly handle that case either. The extensions and bookmarklet's i've tried only apply "paragraphSpacing" between "p" elements.

mdebbar · 2025-08-15T16:17:26Z

+    if (parsed != null && !parsed.isNaN) {
+      styleProperty = parsed;
+    }


Suggested change

if (parsed != null && !parsed.isNaN) {

styleProperty = parsed;

}

styleProperty = parsed;

The extra checks are not necessary. parseFloat() already handles the isNaN case.

mdebbar · 2025-08-15T16:22:46Z

+  });
+
+  /// The height of the text, as a multiple of the font size.
+  final double? lineHeight;


IMO it doesn't make sense to set line height to an absolute number for a11y purposes. Percentage makes sense but it's basically the same as unitless, i.e. 150% == 1.5.

mdebbar · 2025-08-15T16:30:33Z

+    style.lineHeight = '${spacingDefault}px';
+    style.letterSpacing = '${spacingDefault}px';
+    style.wordSpacing = '${spacingDefault}px';
+    style.margin = '0px 0px ${spacingDefault}px 0px';


Applying these default styles directly on the element, are browser extensions able to override them via global styles?

If I'm understanding correctly yes they are able to override them via global styles, at least from the ones i've tried.

Normally, inline styles that are set directly on the element (which is what you are doing here) will override any global styles. But extensions are using !important to force their styles to take precedence: https://github.com/actum/text-spacing-editor/blob/6782a09bfd55d5ad7791c498804ecfbf28ece0dc/helpers/buildCSSToInject.ts#L20-L30

So you are good 🙂

…ake into account strutStyle.forceStrutHeight

LongCatIsLooong

LGTM with nits.

LongCatIsLooong · 2025-11-07T22:48:47Z

+    bool? forceStrutHeight,
    String? debugLabel,
    String? package,
-  }) : assert(fontSize == null || fontSize > 0),


Still the font size can't be negative? or this is checked in the unnamed constructor?

That is checked in the unnamed constructor.

LongCatIsLooong · 2025-11-07T22:49:42Z

    String? package,
-  }) : assert(fontSize == null || fontSize > 0),
-       assert(leading == null || leading >= 0),
-       assert(package == null || fontFamily != null || fontFamilyFallback != null),


Are these two asserts also in the unnamed constructor?

Yes these asserts are also present in the unnamed constructor.

LongCatIsLooong · 2025-11-07T22:56:33Z

+  }) : this(
+         fontFamily: fontFamily != null
+             ? (package == null ? fontFamily : 'packages/$package/$fontFamily')
+             : textStyle.fontFamily,


I guess this is not a bug introduced in this patch, but the fontFamilyFallback needs to embed the package path too.

I think it does end up doing this but through a getter.

List<String>? get fontFamilyFallback { if (_package != null && _fontFamilyFallback != null) { return _fontFamilyFallback.map((String family) => 'packages/$_package/$family').toList(); } return _fontFamilyFallback; }

LongCatIsLooong · 2025-11-07T22:59:16Z


      spellCheckResults = SpellCheckResults(text, suggestions);
-      renderEditable.text = buildTextSpan();
+      final double? lineHeightScaleFactor = mounted


why's the mounted check needed? Generally the state should unregister itself from these services in dispose?

There were no mounted checks before.

Because this logic is happening in an async method, the lint complained we were not checking mounted.

LongCatIsLooong · 2025-11-07T23:04:39Z

+// must also be updated.
+// TODO(Renzo-Olivares): Remove after investigating a solution for overriding all
+// styles for children in an [InlineSpan] tree, see: https://github.com/flutter/flutter/issues/177952.
+class _OverridingTextStyleTextSpanUtils {


nit: can these just be two private functions without the utility class?

LongCatIsLooong · 2025-11-07T23:06:08Z

+    return TextSpan(
+      text: textSpan.text,
+      children: textSpan.children?.map((InlineSpan child) {
+        if (child is TextSpan && child.runtimeType == TextSpan) {


why the runtimeType == check? IIRC the reason we need the is TextSpan is that InlineSpan doesn't specify its child model. But TextSpan does specify its child model.

If someone is adding new features to their TextSpan subclass they would be lost during this recreation because we don’t own the subclass and cannot recreate it accurately.

LongCatIsLooong · 2025-11-07T23:08:03Z

  ///    supported.
  final bool supportsShowingSystemContextMenu;

+  /// The height of the text, as a multiple of the font size.


nit: height override? same for the other two parameters since they take precedence over existing local text style values?

Renzo-Olivares · 2025-11-07T23:32:05Z

Closing this in favor of #178081

Original PR/Discussion: #172915 # Framework: * `EditableText`/`SelectableText`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. Note `SelectableText` is built on `EditableText` so it also applies these overrides. * `Text`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. * Exposes line height override through `MediaQueryData.lineHeightScaleFactorOverride` and `maybeLineHeightScaleFactorOverrideOf(context)`. * Exposes letter spacing override through `MediaQueryData.letterSpacingOverride` and `maybeLetterSpacingOverrideOf(context)`. * Exposes word spacing override through `MediaQueryData.wordSpacingOverride` and `maybeWordSpacingOverrideOf(context)`. * Exposes paragraph spacing override through `MediaQueryData.paragraphSpacingOverride` and `maybeParagraphSpacingOverrideOf(context)`. * `MediaQuery.applyTextStyleOverrides()` \ `MediaQueryData.applyTextStyleOverrides()` to be able to reset/override the text spacing settings on `MediaQueryData`. # Engine: * Introduces new members on `PlatformDispatcher` API that hold the text spacing properties that are overridden on the web. * We provide the `lineHeightScaleFactorOverride`, `letterSpacingOverride`, `wordSpacingOverride`, and `paragraphSpacingOverride` on the web by attaching a `ResizeObserver` to an off-screen hidden element, when its size changes we capture its text spacing CSS properties, and notify the framework through `onMetricsChanged`. Fixes #142712 https://github.com/user-attachments/assets/aaaa3e74-c232-4956-acd2-ae1a4487e415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

Original PR/Discussion: flutter#172915 # Framework: * `EditableText`/`SelectableText`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. Note `SelectableText` is built on `EditableText` so it also applies these overrides. * `Text`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. * Exposes line height override through `MediaQueryData.lineHeightScaleFactorOverride` and `maybeLineHeightScaleFactorOverrideOf(context)`. * Exposes letter spacing override through `MediaQueryData.letterSpacingOverride` and `maybeLetterSpacingOverrideOf(context)`. * Exposes word spacing override through `MediaQueryData.wordSpacingOverride` and `maybeWordSpacingOverrideOf(context)`. * Exposes paragraph spacing override through `MediaQueryData.paragraphSpacingOverride` and `maybeParagraphSpacingOverrideOf(context)`. * `MediaQuery.applyTextStyleOverrides()` \ `MediaQueryData.applyTextStyleOverrides()` to be able to reset/override the text spacing settings on `MediaQueryData`. # Engine: * Introduces new members on `PlatformDispatcher` API that hold the text spacing properties that are overridden on the web. * We provide the `lineHeightScaleFactorOverride`, `letterSpacingOverride`, `wordSpacingOverride`, and `paragraphSpacingOverride` on the web by attaching a `ResizeObserver` to an off-screen hidden element, when its size changes we capture its text spacing CSS properties, and notify the framework through `onMetricsChanged`. Fixes flutter#142712 https://github.com/user-attachments/assets/aaaa3e74-c232-4956-acd2-ae1a4487e415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

Original PR/Discussion: flutter/flutter#172915 # Framework: * `EditableText`/`SelectableText`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. Note `SelectableText` is built on `EditableText` so it also applies these overrides. * `Text`, applies `lineHeightScaleFactorOverride`, `wordSpacingOverride`, and `letterSpacingOverride` to it's `TextStyle` similarly to how we already do for bold platform overrides. * Exposes line height override through `MediaQueryData.lineHeightScaleFactorOverride` and `maybeLineHeightScaleFactorOverrideOf(context)`. * Exposes letter spacing override through `MediaQueryData.letterSpacingOverride` and `maybeLetterSpacingOverrideOf(context)`. * Exposes word spacing override through `MediaQueryData.wordSpacingOverride` and `maybeWordSpacingOverrideOf(context)`. * Exposes paragraph spacing override through `MediaQueryData.paragraphSpacingOverride` and `maybeParagraphSpacingOverrideOf(context)`. * `MediaQuery.applyTextStyleOverrides()` \ `MediaQueryData.applyTextStyleOverrides()` to be able to reset/override the text spacing settings on `MediaQueryData`. # Engine: * Introduces new members on `PlatformDispatcher` API that hold the text spacing properties that are overridden on the web. * We provide the `lineHeightScaleFactorOverride`, `letterSpacingOverride`, `wordSpacingOverride`, and `paragraphSpacingOverride` on the web by attaching a `ResizeObserver` to an off-screen hidden element, when its size changes we capture its text spacing CSS properties, and notify the framework through `onMetricsChanged`. Fixes #142712 https://github.com/user-attachments/assets/aaaa3e74-c232-4956-acd2-ae1a4487e415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jul 29, 2025

gemini-code-assist Bot reviewed Jul 29, 2025

View reviewed changes

Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/platform_dispatcher.dart Outdated

Renzo-Olivares force-pushed the typography-overrides branch from ec1dcf9 to 496ed5b Compare July 30, 2025 18:18

Renzo-Olivares changed the title ~~[Web] Listen to text spacing overrides through TypographySettings~~ [web] Listen to text spacing overrides through TypographySettings Jul 30, 2025

Renzo-Olivares force-pushed the typography-overrides branch 2 times, most recently from 8e12a12 to 899258a Compare July 31, 2025 20:25

github-actions Bot added the f: material design flutter/packages/flutter/material repository. label Aug 4, 2025

Renzo-Olivares force-pushed the typography-overrides branch 5 times, most recently from 8dce1f5 to 85239f2 Compare August 7, 2025 22:40

Renzo-Olivares marked this pull request as ready for review August 7, 2025 23:44

Renzo-Olivares commented Aug 7, 2025

View reviewed changes

Renzo-Olivares commented Aug 8, 2025

View reviewed changes

Renzo-Olivares requested review from chunhtai and mdebbar August 8, 2025 18:57

chunhtai reviewed Aug 14, 2025

View reviewed changes

mdebbar reviewed Aug 15, 2025

View reviewed changes

loic-sharma reviewed Aug 18, 2025

View reviewed changes

Comment thread engine/src/flutter/lib/ui/window.dart Outdated

chunhtai self-requested a review August 29, 2025 16:11

Renzo-Olivares force-pushed the typography-overrides branch 2 times, most recently from b45142c to 582f2e5 Compare September 2, 2025 23:13

github-actions Bot added the a: tests "flutter test", flutter_test, or one of our tests label Sep 3, 2025

Renzo-Olivares force-pushed the typography-overrides branch from 8bae26c to dccfc06 Compare September 3, 2025 17:25

Renzo Olivares added 11 commits November 4, 2025 09:25

more docs

93ffc65

The framework should not apply paragraphSpacing automatically for now

2152d70

update docs

3861d4b

Add test

3dfdf07

more tests

f8e04ce

Update solution to penetrate all text spans in a text span tree and t…

c9b7c61

…ake into account strutStyle.forceStrutHeight

clean up

ed261c9

update tests

32ee8b9

Add more tests

b321380

Address reviewer comments

4cfe1af

updates

572abd3

Renzo-Olivares force-pushed the typography-overrides branch from 4f31b33 to 572abd3 Compare November 4, 2025 17:25

Renzo Olivares added 6 commits November 4, 2025 10:32

strutStyle comments

daf5306

update paragraphSpacingOverride docs

21344e9

Use methods instead of a subclass

bb990fe

remove copyWith

cf2776f

make default font size calculation safe

bb7391a

fix StrutStyle issues

7b7eab4

github-actions Bot added the f: cupertino flutter/packages/flutter/cupertino repository label Nov 5, 2025

Renzo Olivares added 2 commits November 5, 2025 12:38

Update TextSpan overrides

735971b

Add MediaQuery.updateTextStyleOverrides

0f9c1e7

Renzo-Olivares mentioned this pull request Nov 5, 2025

Listen to text spacing overrides on the web #178081

Merged

9 tasks

LongCatIsLooong approved these changes Nov 7, 2025

View reviewed changes

Renzo-Olivares closed this Nov 7, 2025

Uh oh!

Conversation

Renzo-Olivares commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Framework:

Engine:

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Renzo-Olivares Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chunhtai Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares commented Aug 14, 2025

Uh oh!

Choose a reason for hiding this comment

Renzo-Olivares commented Jul 29, 2025 •

edited

Loading

Renzo-Olivares Aug 7, 2025 •

edited

Loading

Renzo-Olivares Aug 7, 2025 •

edited

Loading

chunhtai Aug 14, 2025 •

edited

Loading

Renzo-Olivares Sep 12, 2025 •

edited

Loading

loic-sharma Sep 15, 2025 •

edited

Loading

chunhtai Sep 22, 2025 •

edited

Loading

chunhtai Aug 14, 2025 •

edited

Loading