Skip to content

[CP-beta]Update warnGradleVersion to 8.7.0#172787

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.35-candidate.0from
flutteractionsbot:cp-beta-e12d263d3ddf75f766642eca327954f842b33e48
Jul 28, 2025
Merged

[CP-beta]Update warnGradleVersion to 8.7.0#172787
auto-submit[bot] merged 1 commit into
flutter:flutter-3.35-candidate.0from
flutteractionsbot:cp-beta-e12d263d3ddf75f766642eca327954f842b33e48

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#172789

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
#172789
#172789 Using a lower version of Gradle results in a warning message to bump to a minimum of version 8.7.2, but the warning should bump to a minimum of version 8.7.0

Reids edit:
flutter/172789 When building for Android, Change warning for minimum gradle version from 8.7.2 to 8.7.0.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

When on a lower version of Gradle, Flutter tooling would log a suggestion to bump to a minimum of 8.7.0 instead of 8.7.2

Workaround:

Is there a workaround for this issue?

Yes, the user would bump to a higher valid version of Gradle.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Use a low version of gradle and see that the Flutter tool recommends using gradle 8.7.0

When using a lower Gradle version, a warning to update to at least 8.7.2
is shown, but 8.7.2 is not a valid version. Changed warnGradleVersion
from 8.7.2 to 8.7.0.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jul 25, 2025
@flutteractionsbot flutteractionsbot requested a review from a team as a code owner July 25, 2025 20:42
@flutteractionsbot

Copy link
Copy Markdown
Contributor Author

@jesswrd please fill out the PR description above, afterwards the release team will review this request.

@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jul 25, 2025
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 25, 2025
@jesswrd jesswrd requested a review from eyebrowsoffire July 25, 2025 21:27
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2025
@auto-submit auto-submit Bot merged commit 31cf7a8 into flutter:flutter-3.35-candidate.0 Jul 28, 2025
141 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants