Skip to content

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 3, 2018

Also reverts attempted fix:

Also reverts:

This reverts commit 22c12f9.
This reverts commit 40ddf01.
This reverts commit 50bd39a.

@cbracken
Copy link
Member Author

cbracken commented May 3, 2018

Reverting #17220 and the followup attempted fix #17257 so we can get changes unblocked.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also reverts attempted fix:
* fix names of demos in perf tests (flutter#17257)

Also reverts:
* Add longPress/Tap event to SemanticService (flutter#16945)

This reverts commit 22c12f9.
This reverts commit 40ddf01.
This reverts commit 50bd39a.
@cbracken cbracken changed the title Revert "Gallery demos: reordered and retitled (#17220)" Revert longPress/Tap and Gallery changes May 3, 2018
@cbracken cbracken merged commit 322eb81 into flutter:master May 3, 2018
@cbracken cbracken deleted the rollback branch May 3, 2018 23:51
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
Revert longPress/Tap and Gallery changes
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants