-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[ Widget Preview ] Initial work to support reacting to IDE events #172040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Widget Preview ] Initial work to support reacting to IDE events #172040
Conversation
Adds support for a subset of the DTD `Editor` service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for: - Source file selection events - Editor theme change events This change does not introduce any new functionality that makes use of these new DTD `Editor` events.
jyameo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! However, there are a few CI failures on widget_preview_test.dart. please take a look.
Should be fixed now 😄 |
jyameo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
flutter/flutter@a930ec1...cc3110c 2025-07-15 codefu@google.com feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132) 2025-07-15 fluttergithubbot@gmail.com Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145) 2025-07-15 bkonyi@google.com [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141) 2025-07-15 737941+loic-sharma@users.noreply.github.com Reland "Add feature flags to the framework" (flutter/flutter#171545) 2025-07-14 pedromassango.developer@gmail.com chore: unskip tests cases (flutter/flutter#172031) 2025-07-14 jmccandless@google.com Route transition duration (flutter/flutter#171109) 2025-07-14 chinmaygarde@google.com [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134) 2025-07-14 jessiewong401@gmail.com Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128) 2025-07-14 mdebbar@google.com [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130) 2025-07-14 kjlubick@users.noreply.github.com Use granular skparagraph targets (flutter/flutter#161676) 2025-07-14 bkonyi@google.com [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123) 2025-07-14 kjlubick@users.noreply.github.com [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104) 2025-07-14 codefu@google.com fix: documentation around led launch broken (flutter/flutter#171983) 2025-07-14 bkonyi@google.com [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120) 2025-07-14 jason-simmons@users.noreply.github.com Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033) 2025-07-14 chinmaygarde@google.com [Impeller] Fix broken image links in documentation. (flutter/flutter#171465) 2025-07-14 mohellebiabdessalem@gmail.com remove `x86` in CI builder linux_android_emulator (flutter/flutter#170964) 2025-07-14 mohellebiabdessalem@gmail.com remove `x86` in flutter_gdb (flutter/flutter#170966) 2025-07-14 mohellebiabdessalem@gmail.com fix android studio lint about lambda function (flutter/flutter#172063) 2025-07-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111) 2025-07-14 1961493+harryterkelsen@users.noreply.github.com [web] Delete unused files in the engine (flutter/flutter#172035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…utter#172040) Adds support for a subset of the DTD `Editor` service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for: - Source file selection events - Editor theme change events This change does not introduce any new functionality that makes use of these new DTD `Editor` events.
flutter/flutter@a930ec1...cc3110c 2025-07-15 codefu@google.com feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132) 2025-07-15 fluttergithubbot@gmail.com Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145) 2025-07-15 bkonyi@google.com [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141) 2025-07-15 737941+loic-sharma@users.noreply.github.com Reland "Add feature flags to the framework" (flutter/flutter#171545) 2025-07-14 pedromassango.developer@gmail.com chore: unskip tests cases (flutter/flutter#172031) 2025-07-14 jmccandless@google.com Route transition duration (flutter/flutter#171109) 2025-07-14 chinmaygarde@google.com [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134) 2025-07-14 jessiewong401@gmail.com Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128) 2025-07-14 mdebbar@google.com [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130) 2025-07-14 kjlubick@users.noreply.github.com Use granular skparagraph targets (flutter/flutter#161676) 2025-07-14 bkonyi@google.com [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123) 2025-07-14 kjlubick@users.noreply.github.com [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104) 2025-07-14 codefu@google.com fix: documentation around led launch broken (flutter/flutter#171983) 2025-07-14 bkonyi@google.com [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120) 2025-07-14 jason-simmons@users.noreply.github.com Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033) 2025-07-14 chinmaygarde@google.com [Impeller] Fix broken image links in documentation. (flutter/flutter#171465) 2025-07-14 mohellebiabdessalem@gmail.com remove `x86` in CI builder linux_android_emulator (flutter/flutter#170964) 2025-07-14 mohellebiabdessalem@gmail.com remove `x86` in flutter_gdb (flutter/flutter#170966) 2025-07-14 mohellebiabdessalem@gmail.com fix android studio lint about lambda function (flutter/flutter#172063) 2025-07-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116) 2025-07-14 engine-flutter-autoroll@skia.org Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111) 2025-07-14 1961493+harryterkelsen@users.noreply.github.com [web] Delete unused files in the engine (flutter/flutter#172035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…utter#172040) Adds support for a subset of the DTD `Editor` service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for: - Source file selection events - Editor theme change events This change does not introduce any new functionality that makes use of these new DTD `Editor` events.
…utter#172040) Adds support for a subset of the DTD `Editor` service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for: - Source file selection events - Editor theme change events This change does not introduce any new functionality that makes use of these new DTD `Editor` events.
…utter#172040) Adds support for a subset of the DTD `Editor` service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for: - Source file selection events - Editor theme change events This change does not introduce any new functionality that makes use of these new DTD `Editor` events.
Adds support for a subset of the DTD
Editorservice registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for:This change does not introduce any new functionality that makes use of these new DTD
Editorevents.