[ Widget Previews ] Add analytics for flutter widget-preview start
#171641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracks the following metrics: - Overall launch time with/without generating the widget preview scaffold - Time from detecting a file change within the tracked project to actually loading the updated previews into the previewer Fixes #166418
bkonyi
commented
Jul 4, 2025
|
|
||
| /// Send an analytics event reporting how long it took for a widget preview to be reloaded. | ||
| void reportPreviewReloadTiming() { | ||
| // TODO(bkonyi): only report when files are actually reloaded? |
Contributor
Author
There was a problem hiding this comment.
@anderdobo, what do you think about this? Right now, we'll always report a preview reload timing event, even if the result is no files were hot reloaded into the preview environment (e.g., only whitespace was changed).
Even if a change results in no libraries being reloaded into the preview environment, we still need to do analysis and scan the updated file for changes to the previews defined within the file. That means there is still work being done that will also block processing of further changes to other files.
jyameo
approved these changes
Jul 4, 2025
Contributor
jyameo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding detailed metrics tracking!
Contributor
|
autosubmit label was removed for flutter/flutter/171641, because - The status or check suite Linux build_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/flutter/171641, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…lutter#171641) Tracks the following metrics: - Overall launch time with/without generating the widget preview scaffold - Time from detecting a file change within the tracked project to actually loading the updated previews into the previewer Fixes flutter#166418
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
…lutter#171641) Tracks the following metrics: - Overall launch time with/without generating the widget preview scaffold - Time from detecting a file change within the tracked project to actually loading the updated previews into the previewer Fixes flutter#166418
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…lutter#171641) Tracks the following metrics: - Overall launch time with/without generating the widget preview scaffold - Time from detecting a file change within the tracked project to actually loading the updated previews into the previewer Fixes flutter#166418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks the following metrics:
Fixes #166418