[ Widget Previews ] Add support for Pub Workspaces #171538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the widget previewer to properly handle previews defined across a workspace. This is effectively equivalent to displaying previews from multiple individual projects, which required a fairly significant rework to properly support: - resolving asset paths to the right project - loading assets across projects in the workspace - tracking changes to pubspec.yaml files across the workspace While making this change, it became apparent that we don't need to explicitly list the assets from the various projects explicitly in the scaffold's pubspec.yaml as they're automatically pulled in by adding those project's as dependencies and using the `package/$ASSET_PATH` format to load the assets from the scaffold. This allowed for the removal of a significant amount of logic related to building the scaffold's pubspec. Fixes #169268
bkonyi
commented
Jul 2, 2025
| import '../../src/common.dart'; | ||
| import '../../src/context.dart'; | ||
|
|
||
| // TODO(bkonyi): test pubspec change detection for workspaces |
Contributor
Author
There was a problem hiding this comment.
These tests should be rewritten to utilize some of the utilities that have been added for testing widget preview projects. I'll do this in a follow up to avoid making this PR even larger.
jyameo
approved these changes
Jul 2, 2025
Contributor
jyameo
left a comment
There was a problem hiding this comment.
Overall LGTM! However, there are some test failures to note:
UnimplementedError: workspaceProjectsinwidget_preview_test.dart.- Mismatches between expected and actual URI/path formats in
preview_detector_graph_test.dart.
Contributor
Author
I swear I had run all the widget preview tests before uploading this... apparently not 😅 The failures should be fixed now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
Updates the widget previewer to properly handle previews defined across a workspace. This is effectively equivalent to displaying previews from multiple individual projects, which required a fairly significant rework to properly support: - resolving asset paths to the right project - loading assets across projects in the workspace - tracking changes to pubspec.yaml files across the workspace While making this change, it became apparent that we don't need to explicitly list the assets from the various projects explicitly in the scaffold's pubspec.yaml as they're automatically pulled in by adding those project's as dependencies and using the `package/$ASSET_PATH` format to load the assets from the scaffold. This allowed for the removal of a significant amount of logic related to building the scaffold's pubspec. Fixes flutter#169268
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
Updates the widget previewer to properly handle previews defined across a workspace. This is effectively equivalent to displaying previews from multiple individual projects, which required a fairly significant rework to properly support: - resolving asset paths to the right project - loading assets across projects in the workspace - tracking changes to pubspec.yaml files across the workspace While making this change, it became apparent that we don't need to explicitly list the assets from the various projects explicitly in the scaffold's pubspec.yaml as they're automatically pulled in by adding those project's as dependencies and using the `package/$ASSET_PATH` format to load the assets from the scaffold. This allowed for the removal of a significant amount of logic related to building the scaffold's pubspec. Fixes flutter#169268
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Updates the widget previewer to properly handle previews defined across a workspace. This is effectively equivalent to displaying previews from multiple individual projects, which required a fairly significant rework to properly support: - resolving asset paths to the right project - loading assets across projects in the workspace - tracking changes to pubspec.yaml files across the workspace While making this change, it became apparent that we don't need to explicitly list the assets from the various projects explicitly in the scaffold's pubspec.yaml as they're automatically pulled in by adding those project's as dependencies and using the `package/$ASSET_PATH` format to load the assets from the scaffold. This allowed for the removal of a significant amount of logic related to building the scaffold's pubspec. Fixes flutter#169268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the widget previewer to properly handle previews defined across a workspace. This is effectively equivalent to displaying previews from multiple individual projects, which required a fairly significant rework to properly support:
While making this change, it became apparent that we don't need to explicitly list the assets from the various projects explicitly in the scaffold's pubspec.yaml as they're automatically pulled in by adding those project's as dependencies and using the
package/$ASSET_PATHformat to load the assets from the scaffold. This allowed for the removal of a significant amount of logic related to building the scaffold's pubspec.Fixes #169268