Refactor compositor classes #171414
Merged
Refactor compositor classes #171414
+389
−554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Includes #171409 |
Contributor
Author
|
This is intended as a first step in refactoring to help land #170045 |
mattkae
approved these changes
Jul 2, 2025
Contributor
mattkae
left a comment
There was a problem hiding this comment.
Looks like a solid change to me :)
Contributor
|
The presubmit test failures do look real. |
2cc0068 to
7d3c5a6
Compare
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
7d3c5a6 to
a392005
Compare
Contributor
Author
|
Something weird was going on with main/master, so I've rebased. |
This now requires the widget to be realized and is proving difficult to mock. There will be further PRs that should make this easier - reenable after they land.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 10, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 10, 2025
flutter/flutter@ac12f66...43657f3 2025-07-10 sokolovskyi.konstantin@gmail.com [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 ybz975218925@gmail.com Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 robert.ancell@canonical.com Refactor compositor classes (flutter/flutter#171414) 2025-07-10 matanlurey@users.noreply.github.com Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 ybz975218925@gmail.com Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 30870216+gaaclarke@users.noreply.github.com Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 matt.boetger@gmail.com Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 matanlurey@users.noreply.github.com Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 40898687+dannyvalentesonos@users.noreply.github.com Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 matanlurey@users.noreply.github.com Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 matanlurey@users.noreply.github.com Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 jessiewong401@gmail.com [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 biggs0125@gmail.com Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 codefu@google.com feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 matanlurey@users.noreply.github.com Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 matanlurey@users.noreply.github.com Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 matanlurey@users.noreply.github.com Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 nt4f04uNd@gmail.com Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 matanlurey@users.noreply.github.com Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 matanlurey@users.noreply.github.com Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 kjlubick@users.noreply.github.com [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 10, 2025
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
flutter/flutter@ac12f66...43657f3 2025-07-10 sokolovskyi.konstantin@gmail.com [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 ybz975218925@gmail.com Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 robert.ancell@canonical.com Refactor compositor classes (flutter/flutter#171414) 2025-07-10 matanlurey@users.noreply.github.com Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 ybz975218925@gmail.com Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 30870216+gaaclarke@users.noreply.github.com Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 matt.boetger@gmail.com Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 matanlurey@users.noreply.github.com Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 40898687+dannyvalentesonos@users.noreply.github.com Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 matanlurey@users.noreply.github.com Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 matanlurey@users.noreply.github.com Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 jessiewong401@gmail.com [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 biggs0125@gmail.com Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 codefu@google.com feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 matanlurey@users.noreply.github.com Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 matanlurey@users.noreply.github.com Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 matanlurey@users.noreply.github.com Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 nt4f04uNd@gmail.com Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 matanlurey@users.noreply.github.com Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 matanlurey@users.noreply.github.com Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 kjlubick@users.noreply.github.com [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
It seems this PR has introduced an intermittent bug where on my Linux machine with |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Present frames directly to each view, which maintains its own compositor. This simplifies the compositor so it doesn't need to maintain a map from views to buffers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present frames directly to each view, which maintains its own compositor.
This simplifies the compositor so it doesn't need to maintain a map from views to buffers.