Skip to content

Remove --enable-impeller-3d gn flag #171405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 30, 2025
Merged

Remove --enable-impeller-3d gn flag #171405

auto-submit merged 1 commit into from
Jun 30, 2025

Conversation

@bdero
Copy link
Member

@bdero bdero commented Jun 30, 2025

This flag is no longer used. Impeller Scene was removed a while back and has been rewritten as dart package that runs on Flutter GPU.

@bdero bdero requested review from chinmaygarde and zanderso June 30, 2025 21:38
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 30, 2025
@bdero bdero enabled auto-merge June 30, 2025 21:56
@bdero bdero disabled auto-merge June 30, 2025 22:27
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 30, 2025
Merged via the queue into flutter:master with commit 2c970cc Jun 30, 2025
176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
3dfed99
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
508d720
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
3210d0f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
3aaec9d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
b3a999e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
b0f6151
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
de6e633
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
2d5309b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
69f207a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
84b4a40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
a3dae9c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
a881cfe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
03ad4b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
8fe00c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
1d9ff44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
42e627b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
9ce1c05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
13c1f79
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
adbf22e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
010591f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
8cd9242
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
53c401b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
0b754c2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
cd9ae53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
04d6999
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
e0ad612
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
0f46e66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
eba61ee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
8fca247
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@bdero @mboetger
Remove --enable-impeller-3d gn flag (flutter#171405)
d597c60 
This flag is no longer used. Impeller Scene was removed a while back and
has been rewritten as [dart
package](https://pub.dev/packages/flutter_scene) that runs on Flutter
GPU.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
2778532
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
110eb5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
0ab66a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
8109b24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
2c970cc Remove --enable-impeller-3d gn flag (flutter/flutter#171405)
3c6291f
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@bdero @lucaantonelli
Remove --enable-impeller-3d gn flag (flutter#171405)
fef579e 
This flag is no longer used. Impeller Scene was removed a while back and
has been rewritten as [dart
package](https://pub.dev/packages/flutter_scene) that runs on Flutter
GPU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdero @chinmaygarde