-
Notifications
You must be signed in to change notification settings - Fork 29.8k
feat: add "stamp" to et and create build-time engine_stamp.json #171310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+298
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writes a stamp file, engine_stamp.json, containing interesting
information about this build:
```json
{
"build_date": "2025-06-27T16:35:13.279188",
"build_time_ms": 1751067313279,
"git_revision": "e68e105667e9e5cace56b0431781062b773e4831",
"git_revision_date": "2025-06-27 15:51:55 -0700",
"content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983"
}
```
jtmcdole
commented
Jun 28, 2025
engine/src/flutter/tools/engine_tool/test/commands/stamp_command_test.dart
Show resolved
Hide resolved
Member
Author
|
"That worked?!" {
"build_date": "2025-06-27T17:21:54.171573",
"build_time_ms": 1751070114171,
"git_revision": "37b74c8da150b22a4a66f4ce9bd3714a284211cf",
"git_revision_date": "2025-06-27 15:51:55 -0700",
"content_hash": "8d0c3fec9b907726f1cfb0298a5bf89bba84394e"
} |
engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart
Outdated
Show resolved
Hide resolved
engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart
Outdated
Show resolved
Hide resolved
engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart
Outdated
Show resolved
Hide resolved
engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart
Outdated
Show resolved
Hide resolved
Backdating licenses to match other parts of the engine tool
jason-simmons
approved these changes
Jun 28, 2025
zanderso
approved these changes
Jun 30, 2025
Member
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ suggestion to include logs from subprocesses when there's an error.
engine/src/flutter/tools/engine_tool/lib/src/commands/stamp_command.dart
Outdated
Show resolved
Hide resolved
zanderso
approved these changes
Jun 30, 2025
Member
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…ter#171310) Writes a stamp file, engine_stamp.json, containing interesting information about this build: ```json { "build_date": "2025-06-27T16:35:13.279188", "build_time_ms": 1751067313279, "git_revision": "e68e105667e9e5cace56b0431781062b773e4831", "git_revision_date": "2025-06-27 15:51:55 -0700", "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983" } ``` Later; I'll update to the flutter tool to download this artifact to bin/cache so it can be used instead of git commands.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…ter#171310) Writes a stamp file, engine_stamp.json, containing interesting information about this build: ```json { "build_date": "2025-06-27T16:35:13.279188", "build_time_ms": 1751067313279, "git_revision": "e68e105667e9e5cace56b0431781062b773e4831", "git_revision_date": "2025-06-27 15:51:55 -0700", "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983" } ``` Later; I'll update to the flutter tool to download this artifact to bin/cache so it can be used instead of git commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes a stamp file, engine_stamp.json, containing interesting information about this build:
{ "build_date": "2025-06-27T16:35:13.279188", "build_time_ms": 1751067313279, "git_revision": "e68e105667e9e5cace56b0431781062b773e4831", "git_revision_date": "2025-06-27 15:51:55 -0700", "content_hash": "23542e452fc55890626fd1c5eb77c4788c19f983" }Later; I'll update to the flutter tool to download this artifact to bin/cache so it can be used instead of git commands.