Skip to content

Add feature flags to flutter doctor -v #171307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 1, 2025
Merged

Add feature flags to flutter doctor -v #171307

auto-submit merged 1 commit into from
Jul 1, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jun 27, 2025

Towards #38901.

@matanlurey matanlurey requested review from bkonyi and loic-sharma June 27, 2025 22:48
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 27, 2025
@loic-sharma
Copy link
Member

loic-sharma commented Jun 28, 2025

Example output:

$ flutter doctor --verbose
[!] Flutter (Channel [user-branch], 3.33.0-1.0.pre.729, on macOS 15.5 24F74 darwin-arm64, locale en) [252ms]
    ...
    • Framework revision 9c3e4a7821 (3 hours ago), 2025-06-27 15:47:18 -0700
    • Engine revision 3bc69cb262
    • Dart version 3.9.0 (build 3.9.0-268.0.dev)
    • DevTools version 2.48.0-dev.0
    • Feature flags: enable-web, enable-linux-desktop, enable-macos-desktop, enable-windows-desktop, enable-android, enable-ios, cli-animations, enable-native-assets,
      enable-swift-package-manager
    ...

loic-sharma
loic-sharma reviewed Jun 28, 2025
View reviewed changes
packages/flutter_tools/lib/src/doctor.dart
}
// Add feature flags that are either enabled, or disabled compared to the default setting.
final List<String> featureFlags = <String>[
..._featureFlags.allConfigurableFeatures
Copy link
Member

@loic-sharma loic-sharma Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing splatting + list literal with a .toList() as that's shorter and less indented. I don't feel strongly about this, feel free to skip

loic-sharma
loic-sharma reviewed Jun 28, 2025
View reviewed changes
packages/flutter_tools/lib/src/features.dart
///
/// [Feature.configSetting] is not `null`.
Iterable<Feature> get allConfigurableFeatures {
return allFeatures.where((Feature feature) => feature.configSetting != null);
Copy link
Member

@loic-sharma loic-sharma Jun 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include features that have a environmentOverride?

I don't know why someone would do this, but one could create a feature that has an environmentOverride but not a configSetting.

loic-sharma
loic-sharma approved these changes Jun 28, 2025
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bkonyi bkonyi mentioned this pull request Jun 30, 2025
Merged
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 1, 2025
Merged via the queue into flutter:master with commit 4fbc812 Jul 1, 2025
138 of 139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
199f151 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
7876b99 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
29486d9 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
fb3f569 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
0df961f 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
3808ffb 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
0958f9d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
d335e92 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
c4c8c7b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
2e8c3ea 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
b0e2af3 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
92ee9a0 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
fa6ee75 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
520295e 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
b39d4e8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
3ca07ee 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
096cb83 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
6f041d9 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
39e6425 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
12b0d33 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
0933bf7 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
bb74ff4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
12d2fa5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
106afad 
)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@matanlurey @mboetger
Add feature flags to flutter doctor -v (flutter#171307)
87c56b7 
Towards flutter#38901.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
dcec533 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
d559c69 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
8a6c269 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
ff6cbf5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
4fbc812 Add feature flags to flutter doctor -v (flutter/flutter#171307
ec40d09 
)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@matanlurey @lucaantonelli
Add feature flags to flutter doctor -v (flutter#171307)
b8b0ee9 
Towards flutter#38901.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matanlurey @loic-sharma @bkonyi