Allow minification to be toggled for wasm builds #171211

biggs0125 · 2025-06-26T05:24:11Z

Provides extra minification controls for web builds. Updates the existing --minify flag to pass its value to both JS and wasm (instead of just JS).

Also adds two new flags --minify-js and --minify-wasm which toggle minification for just one of the web targets. While JS minification has a huge impact on code size, wasm minification has a much smaller effect on the program's size. Since minification can obfuscate useful info (like errors) one may want to turn off minification for wasm but leave it on for JS.

The plan is to temporarily use --no-minify-wasm for devtools to help debug some exceptions being seen.

mdebbar

Should we consider removing the --minify flag in favor of the new ones? Thoughts, @kevmoo?

I think what I'm suggesting here is to rename Kevin's --minify flag to --minify-js (which is what it was actually doing), and introduce a new --minify-wasm.

packages/flutter_tools/lib/src/commands/build_web.dart

biggs0125 · 2025-06-27T17:09:45Z

Should we consider removing the --minify flag in favor of the new ones?

My main concern was removing the flag if people are using it in a config somewhere. Perhaps we could start the process to remove the flag in a follow-up?

mdebbar · 2025-06-27T17:12:42Z

My main concern was removing the flag if people are using it in a config somewhere. Perhaps we could start the process to remove the flag in a follow-up?

The flag is recent and I wouldn't expect many people are using it. It also hasn't made it to a stable release yet.

kevmoo · 2025-06-27T18:53:37Z

We should look to see when I put in --minify It might have just been this release in which case it's not breaking to change things for the next ~6 days.

biggs0125 · 2025-06-27T19:36:15Z

Oh nice, I didn't realize it was new. I've gone ahead and removed it then. Thanks!

mdebbar

Thank you! Looks good to me.

mdebbar · 2025-06-27T19:48:30Z

packages/flutter_tools/lib/src/web/compiler_config.dart

  const WasmCompilerConfig({
    super.optimizationLevel,
    this.stripWasm = true,
+    this.minify = true,


Should we set this to false or null for flutter run here:

flutter/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

Lines 432 to 436 in 5b6b621

return WasmCompilerConfig(

optimizationLevel: 0,

stripWasm: false,

renderer: debuggingOptions.webRenderer,

);

?

kevmoo · 2025-06-27T20:02:09Z

WAIT! Please double check when i added that flag! It's been a minute! Okay?

mdebbar · 2025-06-27T20:04:38Z

WAIT! Please double check when i added that flag! It's been a minute! Okay?

@kevmoo I checked. It's only in beta AFAICT: cb3150f

kevmoo · 2025-06-27T20:05:33Z

WONDERFUL! Just wanted to be sure. Thanks, @mdebbar !

packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

kenzieschmoll

a couple comments but lgtm

biggs0125 · 2025-06-27T22:29:43Z

Thanks everyone!

…tter#171211)

Provides extra minification controls for web builds. Updates the existing `--minify` flag to pass its value to both JS and wasm (instead of just JS). Also adds two new flags `--minify-js` and `--minify-wasm` which toggle minification for just one of the web targets. While JS minification has a huge impact on code size, wasm minification has a much smaller effect on the program's size. Since minification can obfuscate useful info (like errors) one may want to turn off minification for wasm but leave it on for JS. The plan is to temporarily use `--no-minify-wasm` for devtools to help debug some exceptions being seen. --------- Co-authored-by: Nate Biggs <natebiggs@google.com>

…tter#171211)

Provides extra minification controls for web builds. Updates the existing `--minify` flag to pass its value to both JS and wasm (instead of just JS). Also adds two new flags `--minify-js` and `--minify-wasm` which toggle minification for just one of the web targets. While JS minification has a huge impact on code size, wasm minification has a much smaller effect on the program's size. Since minification can obfuscate useful info (like errors) one may want to turn off minification for wasm but leave it on for JS. The plan is to temporarily use `--no-minify-wasm` for devtools to help debug some exceptions being seen. --------- Co-authored-by: Nate Biggs <natebiggs@google.com>

Add extra minification support for wasm compilations.

da6e940

biggs0125 requested a review from kenzieschmoll June 26, 2025 05:24

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 26, 2025

Fix web_test

7daf761

biggs0125 requested a review from mdebbar June 26, 2025 22:47

mdebbar reviewed Jun 27, 2025

View reviewed changes

packages/flutter_tools/lib/src/commands/build_web.dart Outdated Show resolved Hide resolved

Update other invocation of JsCompilerConfig

c9ed83a

Remove standalone --minify flag.

b9dc44b

mdebbar approved these changes Jun 27, 2025

View reviewed changes

kenzieschmoll reviewed Jun 27, 2025

View reviewed changes

packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed Jun 27, 2025

View reviewed changes

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart Outdated Show resolved Hide resolved

kenzieschmoll approved these changes Jun 27, 2025

View reviewed changes

Cleanup tests

bf04174

biggs0125 force-pushed the add-wasm-minify branch from cd91249 to bf04174 Compare June 27, 2025 23:05

biggs0125 added this pull request to the merge queue Jun 28, 2025

Merged via the queue into flutter:master with commit 85486ff Jun 28, 2025
138 checks passed

biggs0125 deleted the add-wasm-minify branch June 28, 2025 18:14

engine-flutter-autoroll mentioned this pull request Jun 28, 2025

Roll Flutter from 2773c0c8e15e to 85486ffffc16 (63 revisions) flutter/packages#9520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

6a7cb83

…tter#171211)

engine-flutter-autoroll mentioned this pull request Jun 29, 2025

Roll Flutter from 2773c0c8e15e to c25f5dd89613 (65 revisions) flutter/packages#9521

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

976e402

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

87c3274

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

3a0f6eb

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

16dae78

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

584e1d9

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

c138f30

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

a5275b6

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

26c900e

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

971a7c8

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

06ab964

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

00f1c7f

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

750eafd

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

e75762f

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

f1bbe1f

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

ecc3f0d

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

a369d19

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

aa1c311

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

522f85b

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

f0d342e

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

2e1c347

…tter#171211)

stuartmorgan-g mentioned this pull request Jul 7, 2025

WASM minification breaks mockito named argument matchers #171702

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

82b3ffe

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

11ce8ed

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

59ee7ab

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

1ee2cab

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

afd508b

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

28df728

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

2af7386

…tter#171211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

85486ff Allow minification to be toggled for wasm builds (flutter/flu…

45fc255

…tter#171211)

	return WasmCompilerConfig(
	optimizationLevel: 0,
	stripWasm: false,
	renderer: debuggingOptions.webRenderer,
	);

Allow minification to be toggled for wasm builds #171211

Allow minification to be toggled for wasm builds #171211

Conversation

biggs0125 commented Jun 26, 2025

Uh oh!

mdebbar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

biggs0125 commented Jun 27, 2025

Uh oh!

mdebbar commented Jun 27, 2025

Uh oh!

kevmoo commented Jun 27, 2025

Uh oh!

biggs0125 commented Jun 27, 2025

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

kevmoo commented Jun 27, 2025

Uh oh!

mdebbar commented Jun 27, 2025

Uh oh!

kevmoo commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

kenzieschmoll left a comment

Choose a reason for hiding this comment

Uh oh!

biggs0125 commented Jun 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mdebbar left a comment •

edited

Loading