Skip to content

[Impeller] eliminate PathReceiver::PathEnd which is only used in one case #170500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 14, 2025
Merged

[Impeller] eliminate PathReceiver::PathEnd which is only used in one case #170500

auto-submit merged 1 commit into from
Jun 14, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented Jun 12, 2025

Fixes: #169719

@flar flar requested a review from a team as a code owner June 12, 2025 01:04
@github-actions github-actions bot added platform-android Android applications specifically platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests team-ios Owned by iOS platform team labels Jun 12, 2025
@flar flar requested a review from dkwingsmt June 12, 2025 01:07
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jun 12, 2025

The RSuperellipse part looks good to me!

@flar flar requested review from gaaclarke and jonahwilliams June 12, 2025 19:45
gaaclarke
gaaclarke approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you update the description for this pr to a phrase like "eliminates PathReceiver::PathEnd"?

@flar flar changed the title [Impeller] PathReceiver::PathEnd only useful for one subclass [Impeller] eliminate PathReceiver::PathEnd which is only used in one case Jun 12, 2025
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 14, 2025
Merged via the queue into flutter:master with commit ba56e06 Jun 14, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 14, 2025
alex-medinsh pushed a commit to alex-medinsh/flutter that referenced this pull request Jun 16, 2025
@flar @alex-medinsh
[Impeller] eliminate PathReceiver::PathEnd which is only used in one …
eecbfb0 
…case (flutter#170500)

Fixes: flutter#169719
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
26affd1 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
e645b21 
… in one case (flutter/flutter#170500)
This was referenced Jun 17, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
1e234f9 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
fea3fd3 
… in one case (flutter/flutter#170500)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
b5d07b8 
… in one case (flutter/flutter#170500)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
0f6c125 
… in one case (flutter/flutter#170500)
This was referenced Jun 17, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
7cf4412 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
0e0d72b 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
363ffda 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
22b42e5 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
20ffc16 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
b7f793b 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
619f869 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
bd510c0 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
4126167 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
2b652ff 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
fa3ba52 
… in one case (flutter/flutter#170500)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@flar @mboetger
[Impeller] eliminate PathReceiver::PathEnd which is only used in one …
139ea11 
…case (flutter#170500)

Fixes: flutter#169719
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
e69e7ff 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
41a52a2 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
9e3b78d 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
478d055 
… in one case (flutter/flutter#170500)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
ba56e06 [Impeller] eliminate PathReceiver::PathEnd which is only used…
6f8f9c1 
… in one case (flutter/flutter#170500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. platform-android Android applications specifically platform-ios iOS applications specifically team-ios Owned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] eliminate PathReceiver.PathEnd

3 participants

@flar @dkwingsmt @gaaclarke