Skip to content

[ Tool ] Report Android x86 target devices as unsupported #170282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 10 commits into from
Jun 25, 2025
Merged

[ Tool ] Report Android x86 target devices as unsupported #170282

auto-submit merged 10 commits into from
Jun 25, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jun 9, 2025

No description provided.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Jun 9, 2025
@bkonyi
Copy link
Contributor Author

bkonyi commented Jun 9, 2025

@jmagman does this look like roughly the right thing to do? Adding TargetPlatform.android_x86 back would mean we need to update every switch statement on a TargetPlatform to handle a case that should never happen.

@bkonyi bkonyi requested a review from jmagman June 12, 2025 16:45
@bkonyi bkonyi marked this pull request as ready for review June 12, 2025 16:45
@bkonyi bkonyi requested a review from a team as a code owner June 12, 2025 16:45
@bkonyi bkonyi requested a review from matanlurey June 13, 2025 18:13
matanlurey
matanlurey requested changes Jun 16, 2025
View reviewed changes
@bkonyi bkonyi requested a review from matanlurey June 24, 2025 17:09
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit b6ea64b Jun 25, 2025
142 checks passed
@auto-submit auto-submit bot deleted the add_x86_device_unsupported branch June 25, 2025 17:12
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
9358859 
…utter/flutter#170282)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
ee06227 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
7dbbc90 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
2ef230e 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
65bbd77 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
ece56a4 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
b3c7ead 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
65e31f5 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
348a534 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
b6ea64bee [ Tool ] Report Android x86 target devices as unsupported (f…
0f5ea09 
…lutter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
828f9ba 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
4276c50 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
6906a96 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
672c2fe 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
82d658d 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
edc26c2 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
8421853 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
fad8208 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
50e0a48 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
386ee5b 
…utter/flutter#170282)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@bkonyi @mboetger
[ Tool ] Report Android x86 target devices as unsupported (flutter#17…
7cba71f 
…0282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
8dad173 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
5396692 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
668cdd1 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
7d8d7d0 
…utter/flutter#170282)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
b6ea64b [ Tool ] Report Android x86 target devices as unsupported (fl…
9f8561f 
…utter/flutter#170282)
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 9, 2025
@JSUYA
Use TargetPlatform.tester enum instead due to Android x86 being unsup…
574f0df 
…ported

flutter/flutter#170282
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 11, 2025
@JSUYA
Use TargetPlatform.tester enum instead due to Android x86 being unsup…
a8812b9 
…ported

flutter/flutter#170282
flutter/flutter#169884
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 11, 2025
@JSUYA
Use TargetPlatform.tester enum instead due to Android x86 being unsup…
9c0022e 
…ported

flutter/flutter#170282
flutter/flutter#169884
@romaingyh romaingyh mentioned this pull request Sep 17, 2025
Closed
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025
@JSUYA
Use TargetPlatform.tester enum instead due to Android x86 being unsup…
3c14534 
…ported

flutter/flutter#170282
flutter/flutter#169884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees

No one assigned

Labels

a: desktop Running on desktop platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkonyi @matanlurey