Fix infinite loop in CupertinoSliverNavigationBar collapse animation by adding bounds check for target scroll position #170210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by adding bounds check for target scroll position
…ionBar collapse animation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
Author
|
@victorsanni, could you please take a look at this once you have a chance? 🙏 I'm not really sure why the Mac_arm64 and Mac_x64 "tool_test_commands" tests are failing. 🤷 |
victorsanni
approved these changes
Jun 9, 2025
Contributor
victorsanni
left a comment
There was a problem hiding this comment.
LGTM with a nit. Thanks for the fix.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
Contributor
Author
|
@MitchellGoodwin @victorsanni how likely is it for this fix to make it into a CP? |
…animation-infinite-loop
…animation-infinite-loop
Contributor
Very unlikely. While it's not a new feature, it's also not a crash or something that severely breaks customers. |
victorsanni
approved these changes
Jun 11, 2025
Contributor
Author
I see. I was under the impression that #164458 was labelled as a P2 because it has a particularly severe impact on Android. |
…animation-infinite-loop
…animation-infinite-loop
…animation-infinite-loop
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…by adding bounds check for target scroll position (flutter#170210) This pull request includes a fix to the `CupertinoSliverNavigationBarState` class in the `nav_bar.dart` file. The change ensures that the `animateTo` method is only called when the `target` is within the valid scroll extent range, i.e. `target <= position.maxScrollExtent`. Fixes flutter#164458 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…imation by adding bounds check for target scroll position (flutter/flutter#170210)
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…by adding bounds check for target scroll position (flutter#170210) This pull request includes a fix to the `CupertinoSliverNavigationBarState` class in the `nav_bar.dart` file. The change ensures that the `animateTo` method is only called when the `target` is within the valid scroll extent range, i.e. `target <= position.maxScrollExtent`. Fixes flutter#164458 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a fix to the
CupertinoSliverNavigationBarStateclass in thenav_bar.dartfile. The change ensures that theanimateTomethod is only called when thetargetis within the valid scroll extent range, i.e.target <= position.maxScrollExtent.Fixes #164458
Pre-launch Checklist
///).