Skip to content

Conversation

@matanlurey
Copy link
Contributor

No description provided.

@matanlurey matanlurey requested a review from zanderso May 30, 2025 19:45
@zanderso
Copy link
Member

IIRC there are recipes (or other configs?) that try to find these strings in this file, and we have to clean those up first. If the pre-subs don't fail and show us where those are, I'll help find them.

@matanlurey
Copy link
Contributor Author

If the pre-subs don't fail and show us where those are, I'll help find them.

Looks like no presub failures - I can check the recipes

@zanderso
Copy link
Member

I was thinking of this: https://flutter.googlesource.com/infra/+/refs/heads/main/config/flutter_config.star#67. Since there isn't a windows_android entry in that file, I think this PR could be safe.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 11bf180 May 30, 2025
153 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@gaaclarke
Copy link
Member

I think this may have caused a dashboard error in Linux ci_yaml flutter roller:

[P62488 16:14:07.061 generate.go:104 I] Generating configs using lucicfg v1.45.0...
Traceback (most recent call last):
  //main.star:328:21: in <toplevel>
  //flutter_config.star:43:25: in _setup
  //flutter_config.star:71:48: in _drone_prod_builders
  //lib/ci_yaml/ci_yaml.star:125:47: in _legacy_swarming_caches
Error: key "linux_android" not in dict<string,proto.Message<scheduler.SchedulerConfig.PlatformProperties>>

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19329/overview

It showed up in my build but hasn't backpropagated to this commit yet.

@gaaclarke
Copy link
Member

Reason for revert: breaks Linux ci_yaml flutter roller https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19333/overview

@gaaclarke gaaclarke added the revert Autorevert PR (with "Reason for revert:" comment) label May 30, 2025
auto-submit bot pushed a commit that referenced this pull request May 30, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label May 30, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 31, 2025
…" (#169799)

<!-- start_original_pr_link -->
Reverts: #169783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaks `Linux ci_yaml flutter roller`
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19333/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {zanderso}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@matanlurey
Copy link
Contributor Author

Fixing downstream here: http://go/flutter-cl/66120

@Pilgrims360

This comment was marked as spam.

matanlurey added a commit to matanlurey/flutter that referenced this pull request Jun 2, 2025
…flutter#169783)" (flutter#169799)"

This reverts commit 99f7498.

Infrastructure was updated in http://go/flutter-cl/66120 to avoid future failures.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants