-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Remove legacy platforms in .ci.yaml with 0 usages.
#169783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy platforms in .ci.yaml with 0 usages.
#169783
Conversation
|
IIRC there are recipes (or other configs?) that try to find these strings in this file, and we have to clean those up first. If the pre-subs don't fail and show us where those are, I'll help find them. |
Looks like no presub failures - I can check the recipes |
|
I was thinking of this: https://flutter.googlesource.com/infra/+/refs/heads/main/config/flutter_config.star#67. Since there isn't a windows_android entry in that file, I think this PR could be safe. |
|
I think this may have caused a dashboard error in https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19329/overview It showed up in my build but hasn't backpropagated to this commit yet. |
|
Reason for revert: breaks |
This reverts commit 11bf180.
…" (#169799) <!-- start_original_pr_link --> Reverts: #169783 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: gaaclarke <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: breaks `Linux ci_yaml flutter roller` https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19333/overview <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: matanlurey <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {zanderso} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: No description provided. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
|
Fixing downstream here: http://go/flutter-cl/66120 |
This comment was marked as spam.
This comment was marked as spam.
…flutter#169783)" (flutter#169799)" This reverts commit 99f7498. Infrastructure was updated in http://go/flutter-cl/66120 to avoid future failures.
No description provided.