Skip to content

[Impeller] Fix rotated CircleGeometry coverage #169743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
May 31, 2025
Merged

[Impeller] Fix rotated CircleGeometry coverage #169743

auto-submit merged 5 commits into from
May 31, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented May 30, 2025

Fixes #169710

CircleGeometry bounds were incorrect under rotation, worst at 45 degrees.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 30, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 30, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169743 at sha ba9534c

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label May 30, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 30, 2025

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169743 at sha 02ce4a6

@flar flar requested a review from jason-simmons May 30, 2025 21:17
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 31, 2025
Merged via the queue into flutter:master with commit 8e44cc2 May 31, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
23227df 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
b18e84b 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
3e1f0e1 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
af6b3c0 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
5f3a458 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
87fa812 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2bc [Impeller] Fix rotated CircleGeometry coverage (flutter/flu…
80f532b 
…tter#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
b52b4c9 
…er#169743)
This was referenced Jun 3, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
d68760e 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
28fc6ba 
…er#169743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
502915d 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
f4db3c6 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
5dbf100 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
49289ba 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
5184489 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
48afc87 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
55b0b10 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
45985ae 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
7f99e98 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
54e4fb0 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
baa1374 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
9578880 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
9a2cb0c 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
60217a7 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
f988508 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
1ad36c2 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
2d8f817 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
e9b93a3 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
ba9c366 
…er#169743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
8e44cc2 [Impeller] Fix rotated CircleGeometry coverage (flutter/flutt…
405fe50 
…er#169743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] CircleGeometry uses bad algorithm to compute transformed bounds

2 participants

@flar @jason-simmons