Skip to content

Mark Linux web_tool_tests as bringup due to being 10%+ flaky #169716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 1 commit into from
May 29, 2025
Merged

Mark Linux web_tool_tests as bringup due to being 10%+ flaky #169716

matanlurey merged 1 commit into from
May 29, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented May 29, 2025

See #169574.

@matanlurey matanlurey requested a review from jtmcdole May 29, 2025 23:25
@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label May 29, 2025
@matanlurey matanlurey mentioned this pull request May 29, 2025
Closed
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 29, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey matanlurey added this pull request to the merge queue May 29, 2025
jonahwilliams
jonahwilliams approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into flutter:master with commit cfd7c9c May 29, 2025
146 of 152 checks passed
@matanlurey matanlurey deleted the mark-web_tool_tests-flaky branch May 29, 2025 23:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
e5ff404 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
2c5dc58 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
f52487e 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
de66652 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
22891fa 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
b7d2e0f 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
70148cb 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
cf7e020 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
825d7dd 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
1c06558 
…aky (flutter/flutter#169716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
bbe5e20 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
79e8157 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
ec16081 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
e953856 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
090b93a 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
1c01082 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
ae1f996 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
8f6a88a 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
4b93363 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
6426913 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
2a1d328 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
0c70619 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
c2b973c 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
9edf242 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
87d0162 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
4dcee28 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
e37ee82 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
422c706 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
aacea75 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
aeb0b78 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
372f32c 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
feb6240 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
a3112a2 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
b2b6480 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
64891fa 
…aky (flutter/flutter#169716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
cfd7c9c Mark Linux web_tool_tests as bringup due to being 10%+ fl…
a617ce8 
…aky (flutter/flutter#169716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matanlurey @cbracken @jtmcdole @jonahwilliams @jason-simmons