Skip to content

IOSSystemContextMenuItem.toString to Diagnosticable #169705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 30, 2025
Merged

IOSSystemContextMenuItem.toString to Diagnosticable #169705

auto-submit merged 2 commits into from
May 30, 2025

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 29, 2025

The IOSSystemContextMenuItem should mixin Diagnosticable instead of overriding toString.

Fixes #169696

@justinmc justinmc requested a review from LouiseHsu May 29, 2025 22:10
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label May 29, 2025
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 4cc47e8 May 30, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
7f10f7b 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
363a074 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
5130b99 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
c8e8966 
…flutter#169705)
@justinmc justinmc deleted the system-context-menu-item-string branch May 30, 2025 19:36
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
12f61d2 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
04bab0f 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
8130004 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
7d3ed28 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
1a254f3 
…flutter#169705)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
779faf5 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
c6f90e4 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
745d252 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
4a063e7 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
4f9e7f7 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
7653b02 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
c3370de 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
e89a48c 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
be2b526 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
e05f3c9 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
d1fc68c 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
01fab6a 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
59257a6 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
6cfff83 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
167d49f 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
5c7c60b 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
9345dae 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
a440f3c 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
90c5b00 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
f9fff56 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
d846144 
…flutter#169705)
@justinmc justinmc mentioned this pull request Jun 23, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2025
@justinmc
Diagnosticable, not toString, for IOSSystemContextMenuItemDatas (#171028
6b76626 
)

Flutter prefers using Diagnosticable instead of toString. See
#169696 and the related PR
#169705. This does the same thing
for a few more classes that I missed.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@justinmc @mboetger
Diagnosticable, not toString, for IOSSystemContextMenuItemDatas (flut…
225ae29 
…ter#171028)

Flutter prefers using Diagnosticable instead of toString. See
flutter#169696 and the related PR
flutter#169705. This does the same thing
for a few more classes that I missed.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
c3c3dfd 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
0b8851b 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
2f30f8f 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
afe3cb7 
…flutter#169705)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
4cc47e8 IOSSystemContextMenuItem.toString to Diagnosticable (flutter/…
4998df4 
…flutter#169705)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@justinmc @lucaantonelli
Diagnosticable, not toString, for IOSSystemContextMenuItemDatas (flut…
65822a3 
…ter#171028)

Flutter prefers using Diagnosticable instead of toString. See
flutter#169696 and the related PR
flutter#169705. This does the same thing
for a few more classes that I missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LouiseHsu LouiseHsu LouiseHsu approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IOSSystemContextMenuItem should use Diagnosticable instead of toString

2 participants

@justinmc @LouiseHsu