Skip to content

Clean up references to deprecated onPop method in docs #169700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 29, 2025
Merged

Clean up references to deprecated onPop method in docs #169700

auto-submit merged 1 commit into from
May 29, 2025

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 29, 2025

onPop is deprecated but was mentioned in the docs. I've put its replacement onPopWithResult in its place. Also, there was one unterminated square bracket that I've fixed.

@justinmc justinmc self-assigned this May 29, 2025
@justinmc justinmc requested a review from chunhtai May 29, 2025 21:19
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: routes Navigator, Router, and related APIs. labels May 29, 2025
@justinmc justinmc marked this pull request as ready for review May 29, 2025 21:19
chunhtai
chunhtai approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 29, 2025
Merged via the queue into flutter:master with commit e315c07 May 29, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@justinmc justinmc deleted the on-pop branch May 29, 2025 23:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
f07f9d2 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
5f24311 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7c4a80f 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
a5a1ce1 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
e241940 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
4138938 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
c679195 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
515d0f0 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
cfcb665 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
6d2afce 
…er/flutter#169700)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
5ac5ceb 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
3bbe451 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
86fa47d 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
e549a47 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
578cde9 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
1f34a9f 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
4e1074f 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
ccb9bdc 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
162144f 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
f1e86cf 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
fa1df5d 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7dff40a 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7599db8 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
96505a1 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
1a7984a 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
5c79519 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7169722 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7fd812c 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
54ae031 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
423db68 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
a93d3b8 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
de43a25 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
0bf3743 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
6c3de12 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
7760818 
…er/flutter#169700)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
e315c07 Clean up references to deprecated onPop method in docs (flutt…
24c7881 
…er/flutter#169700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

@justinmc justinmc

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinmc @chunhtai