Skip to content

Add missing localization generation for widgets #169695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 30, 2025
Merged

Add missing localization generation for widgets #169695

auto-submit merged 2 commits into from
May 30, 2025

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented May 29, 2025

Adds missing localization generation for widget translations
I ran into this issue when I was trying to generate files for https://github.com/flutter/flutter/pull/169150/files, and found out the files were being generated for cupertino and material but not widgets.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 29, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

justinmc
justinmc approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Great catch @LouiseHsu! Looking at git blame this is possibly a 6 year mistake. I'm guessing that at that time we didn't have any translation strings in the widgets library, and when we added some, we forgot to update this script.

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 538cf22 May 30, 2025
151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
198e4fe 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
50ba7ec 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
9d3e30c 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
4856b58 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
b099c9e 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
cbbf15e 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
0fddbcb 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
38cda19 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
ab5e38c 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
538cf22b6 Add missing localization generation for widgets (flutter/fl…
4c63429 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
c5b8049 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
2257cb4 
…ter#169695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
25582b3 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
86caa3b 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
75fecc3 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
df3ba4e 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
54219b7 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
24dd22e 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
ee8c5a1 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
2d05f3b 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
86a4f4b 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
fe50dcd 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
b54b908 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
c851212 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
87aa33a 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
06be396 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
49043ab 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
5c1f1ee 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
00a597e 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
49c672d 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
15b7332 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
f667433 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
8427a39 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
8e6536c 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
2893268 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
f2437e0 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
838d4a4 
…ter#169695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
538cf22 Add missing localization generation for widgets (flutter/flut…
d71cc7c 
…ter#169695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

@justinmc justinmc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LouiseHsu @justinmc