Skip to content

[web] Pass the same optimization level to both stages of JS compiler #169642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 29, 2025
Merged

[web] Pass the same optimization level to both stages of JS compiler #169642

auto-submit merged 2 commits into from
May 29, 2025

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 29, 2025

Ensures that late variables names are cleaned up

Fixes #134423

@kevmoo
[web] Pass the same optimization level to both stages of JS compiler
8790561 
Ensures that late variables names are cleaned up

Fixes #134423
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 29, 2025
@kevmoo kevmoo requested a review from mdebbar May 29, 2025 02:34
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@kevmoo
Copy link
Contributor Author

kevmoo commented May 29, 2025

It'd be nice if we had SOME way to validate the output JS. 🤷

@kevmoo
Copy link
Contributor Author

kevmoo commented May 29, 2025

I did verify before-after to make sure the target bug is fixed, though.

@auto-submit auto-submit bot added this pull request to the merge queue May 29, 2025
Merged via the queue into master with commit a7bab0f May 29, 2025
148 checks passed
@auto-submit auto-submit bot deleted the i134423_same_flags_js branch May 29, 2025 18:12
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
9e85500 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
b5e237c 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
1ce53cc 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
c6a2c88 
…ompiler (flutter/flutter#169642)
This was referenced May 30, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
81fe268 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
4a2b2ba 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
abf2dce 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
e5dd726 
…ompiler (flutter/flutter#169642)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
This was referenced Jun 2, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
aa20a3a 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
c1bfafb 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
8e060ab 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
9f9c4d6 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
2274aef 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
103299f 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
a5c12c6 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
f6578fb 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
e15a799 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
1087329 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
09f8569 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
ee90051 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
8c0b2a0 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
09a49de 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
60dd3fd 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
618977d 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
848a13c 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
4bd7f89 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
5c4c782 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
a24fe23 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
75e092b 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
aa5e5b5 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
d810d25 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
225c90b 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
34918a9 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
bc542a0 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
496a232 
…ompiler (flutter/flutter#169642)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
a7bab0f [web] Pass the same optimization level to both stages of JS c…
b55bb8c 
…ompiler (flutter/flutter#169642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web] unexpected behaviour: main.dart.js contains late final variable names

2 participants

@kevmoo @mdebbar