Skip to content

Removes elevation and thickness from semantics r2 #169382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 30, 2025
Merged

Removes elevation and thickness from semantics r2 #169382

auto-submit merged 2 commits into from
May 30, 2025

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented May 23, 2025

same as #168703, but previous pr seems bugged github

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-fuchsia Fuchsia code specifically f: scrolling Viewports, list views, slivers, etc. platform-windows Building on or for Windows specifically platform-web Web applications specifically a: desktop Running on desktop labels May 23, 2025
@chunhtai chunhtai requested a review from hannah-hyj May 23, 2025 19:08
hannah-hyj
hannah-hyj approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai force-pushed the issues/166092-re branch from 4afdb6c to 70baeeb Compare May 27, 2025 22:46
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 27, 2025

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 70baeeb.

Possible causes:

  • Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
  • Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 9F20:19427A:12477A6:23E51EC:683646B8.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:245:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1233:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1294:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1105:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1038:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1378:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:115:24)
<asynchronous suspension>
#11     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:317:7)
<asynchronous suspension>

@chunhtai chunhtai force-pushed the issues/166092-re branch from 70baeeb to 696b43b Compare May 28, 2025 16:49
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 3c28bb7 May 30, 2025
181 of 182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@flar
Copy link
Contributor

flar commented May 31, 2025

These missing properties seem to be breaking the Google Testing runs on my PRs even after multiple merge-to-ToT attempts.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
764e3a3 
…utter#169382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
027aa09 
…utter#169382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
0d22287 
…utter#169382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
cd5d67e 
…utter#169382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
fbb3e5b 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
e6ad1e3 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
b75ed3c 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
bc19c11 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
e0a3942 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
2fd1b21 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
85347ae 
…utter#169382)
@hannah-hyj
Copy link
Member

hannah-hyj commented Jun 3, 2025

@chunhtai I encountered the same frob issue as @flar. frob link is https://frob.corp.google.com/#/flutter/presubmit?pr=169868 and cl is cl/766224674

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
bc2faad 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
08b08de 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
2d76c22 
…utter#169382)
@chunhtai
Copy link
Contributor Author

chunhtai commented Jun 4, 2025

this pr is rolled into g3, if you are seeing issues, make sure the cl is sync to head. or just push an empty commit to trigger a fresh rerun

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
a9562b5 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
93dfbdc 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
e85b362 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
2390979 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
59d2246 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
20f7407 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
30fc44e 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
aeca8da 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
8cf1178 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
68b91a0 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
2e7cdce 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
6e129d0 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
a610a51 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
a686ad3 
…utter#169382)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
3c28bb7 Removes elevation and thickness from semantics r2 (flutter/fl…
0e6e4e5 
…utter#169382)
@chunhtai chunhtai mentioned this pull request Sep 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-fuchsia Fuchsia code specifically platform-web Web applications specifically platform-windows Building on or for Windows specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @flar @hannah-hyj