[reland] Make build_android_host_app_with_module_aar build using an aar #169311

gmackall · 2025-05-22T21:00:15Z

Relands #169171. I needed to copy the configuration from the FGP that respects the engine.realm file if it exists.

Link to passing run on last commit, when using a local engine: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_android_host_app_with_module_aar/8596/overview

Link to failure before the fix:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_android_host_app_with_module_aar/8505/overview

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…using an aar (flutter#169171)" (flutter#169287)" This reverts commit 5fd7aa2.

…' into reland_aar_test_fix

gmackall · 2025-05-28T18:49:48Z

dev/integration_tests/pure_android_host_apps/android_host_app_v2_embedding/settings.gradle

+            url = uri("../hello/build/host/outputs/repo")
+        }
+        // BEGIN ci only configuration for getting engine artifacts in pre-submit environments
+        def flutterSdkPath = {


This configuration is directly copied from
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt#L55-L84

To sum it up, basically we need to respect the engine.realm file if it exists.

…ing an aar (flutter/flutter#169311)

Gray Mackall added 3 commits May 22, 2025 13:58

Revert "Reverts "Make build_android_host_app_with_module_aar build …

df4dfd1

…using an aar (flutter#169171)" (flutter#169287)" This reverts commit 5fd7aa2.

logs to make engine presubmits run

46b9710

format the meaningless change

2167883

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels May 22, 2025

Gray Mackall and others added 8 commits May 23, 2025 11:14

perhaps relying on FLUTTER_STORAGE_BASE_URL is correct?

848232f

comment begone

9b43e4f

Merge branch 'master' into reland_aar_test_fix

f4bff2a

try to copy fgp internal logic

3f271cf

Merge remote-tracking branch 'refs/remotes/origin/reland_aar_test_fix…

316799f

…' into reland_aar_test_fix

continue trying random things on ci

c2575f2

more random things on ci

b3f7fea

in 3 years or so we will get there

3e5966a

gmackall commented May 28, 2025

View reviewed changes

undo the engine change

8effad3

github-actions bot removed platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels May 28, 2025

gmackall changed the title ~~Revert "Reverts "Make build_android_host_app_with_module_aar build …~~ [reland] Make build_android_host_app_with_module_aar build using an aar May 28, 2025

gmackall marked this pull request as ready for review May 28, 2025 18:53

gmackall requested a review from matanlurey as a code owner May 28, 2025 18:53

Merge branch 'master' into reland_aar_test_fix

a894975

gmackall requested a review from a team May 28, 2025 18:53

reidbaker approved these changes May 29, 2025

View reviewed changes

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

auto-submit bot added this pull request to the merge queue May 29, 2025

Merged via the queue into flutter:master with commit 0d349d7 May 29, 2025
151 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to 0d349d78431a (22 revisions) flutter/packages#9339

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

a393394

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

6122a66

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

7b59541

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

47c4a85

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

f67d79e

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

5d659c9

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

9ec983a

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

633968c

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

3b76027

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

5905ead

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

228c096

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

8582131

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

f377b31

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

cbf1246

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

3119c1b

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

ab8e0df

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

ca4e1ba

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

5d26a59

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

8c269e4

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

6ebe09e

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

994adec

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

1488d89

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

ac73583

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

62d2321

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

33cb8b8

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

a69145f

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

61e6ba7

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

93676db

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

1ecf1af

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

a6833cb

…ing an aar (flutter/flutter#169311)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

0d349d7 [reland] Make build_android_host_app_with_module_aar build us…

67b11d5

…ing an aar (flutter/flutter#169311)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[reland] Make build_android_host_app_with_module_aar build using an aar #169311

[reland] Make build_android_host_app_with_module_aar build using an aar #169311

Uh oh!

gmackall commented May 22, 2025 •

edited

Loading

Uh oh!

gmackall May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[reland] Make build_android_host_app_with_module_aar build using an aar #169311

[reland] Make build_android_host_app_with_module_aar build using an aar #169311

Uh oh!

Conversation

gmackall commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gmackall commented May 22, 2025 •

edited

Loading